Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#47909 closed defect (bug) (invalid)

Soundcloud shortcode fails when SSL is enabled

Reported by: dst Owned by:
Priority: normal Milestone:
Component: Embeds Version:
Severity: normal Keywords:
Cc: Focuses:

Description

The Soundcloud embedded player doesn't load properly, if WordPress / Apache uses SSL.

This is fixable by a minor change in the player code. Please see attached diff.

@@ -167,7 +167,7 @@
 function soundcloud_iframe_widget($options) {
 
   // Build URL
-  $url = 'https://w.soundcloud.com/player/?' . http_build_query($options['params']);
+  $url = 'https://w.soundcloud.com/player?' . http_build_query($options['params']);
   // Set default width if not defined
   $width = isset($options['width']) && $options['width'] !== 0 ? $options['width'] : '100%';
   // Set default height if not defined

Attachments (1)

scembedfix.diff (428 bytes ) - added by dst 7 years ago.
Diff of a proposed fix

Download all attachments as: .zip

Change History (4)

@dst
7 years ago

Diff of a proposed fix

#1 @mukesh27
7 years ago

  • Component ShortcodesEmbeds
  • Keywords reporter-feedback added
  • Version trunk

Hi @dst,

Welcome to WordPress Trac! Thanks for the ticket.

I can't found soundcloud_iframe_widget function in WordPress core files. can you please share the file path in which above function used?

#2 @dst
7 years ago

  • Resolutioninvalid
  • Status newclosed

Yeah this is beyond embarrassing–obviously it's not in core, I'd just forgotten that I'd installed Soundcloud's plugin.

I will now go live in a hole in the ground and never come out. Please close this ticket.

#3 @desrosj
7 years ago

  • Keywords reporter-feedback removed
  • Milestone Awaiting Review

No worries, @dst! Stay out of that hole and come visit again soon!

Note: See TracTickets for help on using tickets.