redirect_guess_404_permalink does not consider public custom posts status

[goaroundagain]

At the moment the redirect_guess_404_permalink function does only consider the default "publish" post status and there is no way around because "publish" ist hard coded:

$post_id = $wpdb->get_var( "SELECT ID FROM $wpdb->posts WHERE $where AND post_status = 'publish'" );

From register_post_status: ​https://codex.wordpress.org/Function_Reference/register_post_status
public: (bool) (optional) Whether posts of this status should be shown in the front end of the site.

For this reason, all post with a custom post status set to public will not be found and return an 404.

I think custom post status with public set to true should also be considered.

[goaroundagain]

Link to the line in canonical.php: https://core.trac.wordpress.org/browser/tags/5.2.1/src/wp-includes/canonical.php#L686

[goaroundagain]

Never mind, just saw that this is fixed with 5.2.2 Great!

[goaroundagain]

Sorry for the confusion, its not fixed. Correct link to the linke in 5.2.2: https://core.trac.wordpress.org/browser/tags/5.2.2/src/wp-includes/canonical.php#L686

[goaroundagain]

Easy fix, just query all public post stati and change the query to IN linke already done with post types in https://core.trac.wordpress.org/browser/tags/5.2.2/src/wp-includes/canonical.php#L673

[SergeyBiryukov]

Related: #47574

[davidbaumwald]

@SergeyBiryukov Is this one still on your radar for 5.3? If not, can me move it to a future milestone?

[garrett-eclipse]

Moving this to a Future Release as we're now in beta3 for 5.3 and this change will need testing and possible unit tests.

[htdat]

Updated the code provided by @goaroundagain and added a unit test for this ticket

[htdat]

The previous diff accidentally removed unnecessary blank link so I updated it again. Basically, this diff is still to update the code provided by @goaroundagain and add a unit test for this ticket

[audrasjb]

I tested the patch and it still applies cleanly against trunk. It looks good on my side: custom post statuses are took into account.

[audrasjb]

Some unit tests were proposed, so let's remove this keyword.

[hellofromTonya]

Today is 5.8 Beta 1. As work continues on this ticket, punting to 5.9.

[audrasjb]

As per today's bug scrub, this enhancement should be considered earlier in the release cycle. Moving to milestone 6.0 with the early workflow keyword.

[costdev]

Unit test updated with @covers tag and minor comment change for consistency.

[peterwilsoncc]

The public attribute when registering post statuses is slightly odd. A post status can be registered as public while not actually been publicly queryable.

<?php
register_post_status(
  'guess404',
  [
    'public' => true,
    'publicly_queryable' => false,
    'internal' => true,
    'protected' => true,
  ]
);

I suggest the following:

<?php
$public_statuses = array_filter( get_post_stati(), 'is_post_status_viewable' );

The IN value will need to run through esc_sql() too. It's mostly a safe bet that the data will be in a form that doesn't need escaping, but for a single function call it's possible to be 100% sure, so let's do that.

---

This may need a dev note too.

[chaion07]

Thanks @goaroundagain for reporting this. We discussed this ticket during a ​recent bug-scrub session. Based on the feedback received from the team we're updating the ticket with the changes:

1. Changing owner from @SergeyBiryukov to @peterwilsoncc since Peter volunteered to push up to a PR. He also wrote the code.
2. Adding keyword needs-dev-note

Props to @peterwilsoncc

Cheers!

https://core.trac.wordpress.org/ticket/47911

[peterwilsoncc]

In the ​linked pull request:

• built upon the previous work in 47911_htdat_3.diff​
• now uses is_post_status_viewable() to determine public post statuses
• added esc_sql to the SQL IN()
• extended tests to include custom public, private, internal and protected statuses

Is pre_redirect_guess_404_permalink adequate in terms of filters or should a filter for the post statuses to include be added?

Naming suggestions are welcome if you think the filter is needed.

[peterwilsoncc]

In 53043:

Canonical: Include all public status in 404 redirects.

In redirect_guess_404_permalink() search for posts using all publicly queryable statuses rather than limiting options to the publish status.

Props goaroundagain, costdev, htdat, audrasjb, chaion07.
Fixes #47911.

Commited in https://core.trac.wordpress.org/changeset/53043

[milana_cap]

Will be added in Field Guide rather than Dev note.