WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 9 months ago

#47943 new defect (bug)

Multisite: Allow site administrators to add new users option and "Add New" wording

Reported by: henry.wright Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch
Focuses: multisite Cc:

Description

If I disable the option Allow site administrators to add new users in Network Admin > Settings and then visit a site as an administrator, I continue to see the text "Add New" in the left hand side menu under "Users"

See the attached image

Attachments (3)

Screenshot 2019-08-28 at 11.37.05.png (51.5 KB) - added by henry.wright 13 months ago.
Screenshot 2019-08-28 at 11.37.31.png (14.9 KB) - added by henry.wright 13 months ago.
47943.diff (935 bytes) - added by henry.wright 9 months ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
13 months ago

  • Component changed from General to Users
  • Focuses multisite added

#2 @SergeyBiryukov
13 months ago

Thanks for the ticket!

Yes, the "Add New" menu item label doesn't match the "Add Existing User" heading in this case.

On the other hand, it's consistent with the other menus: Posts, Media, Pages, etc. all have the "Add New" item. I'm not sure if there's any benefit in changing this one to "Add Existing".

I also think "Add New" is actually more appropriate here: is an existing user of the network, but it's still new to the current site.

Perhaps the option itself could be clarified a bit as to what it actually does.

Current wording:

Add New Users
Allow site administrators to add new users to their site via the "Users → Add New" page

Suggested wording:

Create New Users
Allow site administrators to create new users on their site via the "Users → Add New" page

#3 @henry.wright
13 months ago

I agree the option text is the best text to change. May I suggest an amendment to your proposal?

Create New Users
Allow site administrators to create new users on their site via the "Users → Add New" page

My understanding is the created user is a network user and he or she isn't restricted to the site.

@henry.wright
9 months ago

#4 @henry.wright
9 months ago

  • Keywords has-patch added

@SergeyBiryukov I have attached 47943.diff which amends the text we discussed. I used the suggestion I made in #comment:3

Note: See TracTickets for help on using tickets.