Make WordPress Core

Opened 4 years ago

Closed 18 months ago

Last modified 18 months ago

#47955 closed defect (bug) (fixed)

feed-atom.php references old wp-atom.php xml:base

Reported by: tw2113's profile tw2113 Owned by: audrasjb's profile audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch commit has-unit-tests
Focuses: Cc:

Description

wp-atom.php was a file removed, among some others, in version 3.3 but the template file for Atom based feeds was not updated to reflect.

xml:base="https://mydomain.com/wp-atom.php"

Since this base property is an optional one, we should likely have zero issue with removing it.

Attachments (1)

remove-wp-atom-php-ref.diff (494 bytes) - added by tw2113 4 years ago.

Download all attachments as: .zip

Change History (15)

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Feeds

#2 @tw2113
2 years ago

Just curious if we want to get this into perhaps 5.8 as well, since it's such a minuscule change and shouldn't be breaking of anything that I can think of.

#3 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.8

This ticket was mentioned in Slack in #core by chaion07. View the logs.


2 years ago

#5 @JeffPaul
2 years ago

  • Keywords has-patch added

#6 @chaion07
2 years ago

  • Milestone changed from 5.8 to 5.9

Thanks to @tw2113 for reporting this. We recently reviewed this during a recent [bug-scrub session]https://wordpress.slack.com/archives/C02RQBWTW/p1623097405364300. With Beta 1 coming up in a day punting it to 5.9. Milestone updated. Thanks

#7 @mukesh27
19 months ago

Patch remove-wp-atom-php-ref.diff working fine and ready to marge. Ping @SergeyBiryukov for review.

#9 @audrasjb
19 months ago

  • Keywords needs-refresh added

I added a PR to test the changes, and it looks like we'll need to update the Atom unit tests as well.

#10 @audrasjb
19 months ago

  • Keywords commit added; needs-refresh removed

Tests are passing now.
Marking for commit.

#11 @audrasjb
18 months ago

  • Keywords has-unit-tests added

Updated the unit tests in PR#1966.

#12 @audrasjb
18 months ago

  • Owner set to audrasjb
  • Status changed from new to assigned

Self assigning for commit.

#13 @audrasjb
18 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52267:

Feeds: Remove reference to wp-atom.php in Atom feeds xml:base attribute.

This change removes the optional xml:base attribute for Atom based feeds as wp-atom.php file was removed in [18540] (WordPress 3.3).

Follow-up to [18540].

Props tw2113, audrasjb, mukesh27.
Fixes #47955.

Note: See TracTickets for help on using tickets.