![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#47955 closed defect (bug) (fixed)
feed-atom.php references old wp-atom.php xml:base
| Reported by: | tw2113 | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.9 |
| Component: | Feeds | Version: | |
| Severity: | normal | Keywords: | has-patch commit has-unit-tests |
| Cc: | Focuses: |
Description
wp-atom.php was a file removed, among some others, in version 3.3 but the template file for Atom based feeds was not updated to reflect.
xml:base="https://mydomain.com/wp-atom.php"
Since this base property is an optional one, we should likely have zero issue with removing it.
Attachments (1)
Change History (15)
This ticket was mentioned in Slack in #core by chaion07. View the logs.
5 years ago
#6
@
5 years ago
- Milestone 5.8 → 5.9
Thanks to @tw2113 for reporting this. We recently reviewed this during a recent [bug-scrub session]https://wordpress.slack.com/archives/C02RQBWTW/p1623097405364300. With Beta 1 coming up in a day punting it to 5.9. Milestone updated. Thanks
#7
@
5 years ago
Patch remove-wp-atom-php-ref.diff working fine and ready to marge. Ping @SergeyBiryukov for review.
This ticket was mentioned in PR #1966 on WordPress/wordpress-develop by audrasjb.
5 years ago
#8
Trac ticket: https://core.trac.wordpress.org/ticket/47955
#9
@
5 years ago
- Keywords needs-refresh added
I added a PR to test the changes, and it looks like we'll need to update the Atom unit tests as well.
#10
@
5 years ago
- Keywords commit added; needs-refresh removed
Tests are passing now.
Marking for commit.
5 years ago
#14
Committed in https://core.trac.wordpress.org/changeset/52267
Just curious if we want to get this into perhaps 5.8 as well, since it's such a minuscule change and shouldn't be breaking of anything that I can think of.