#47955 closed defect (bug) (fixed)
feed-atom.php references old wp-atom.php xml:base
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Feeds | Keywords: | has-patch commit has-unit-tests |
| Focuses: | Cc: |
Description
wp-atom.php was a file removed, among some others, in version 3.3 but the template file for Atom based feeds was not updated to reflect.
xml:base="https://mydomain.com/wp-atom.php"
Since this base property is an optional one, we should likely have zero issue with removing it.
Attachments (1)
Change History (15)
This ticket was mentioned in Slack in #core by chaion07. View the logs.
3 years ago
#6
@
3 years ago
- Milestone changed from 5.8 to 5.9
Thanks to @tw2113 for reporting this. We recently reviewed this during a recent [bug-scrub session]https://wordpress.slack.com/archives/C02RQBWTW/p1623097405364300. With Beta 1 coming up in a day punting it to 5.9. Milestone updated. Thanks
#7
@
3 years ago
Patch remove-wp-atom-php-ref.diff working fine and ready to marge. Ping @SergeyBiryukov for review.
This ticket was mentioned in PR #1966 on WordPress/wordpress-develop by audrasjb.
3 years ago
#8
Trac ticket: https://core.trac.wordpress.org/ticket/47955
#9
@
3 years ago
- Keywords needs-refresh added
I added a PR to test the changes, and it looks like we'll need to update the Atom unit tests as well.
#10
@
3 years ago
- Keywords commit added; needs-refresh removed
Tests are passing now.
Marking for commit.
#12
@
3 years ago
- Owner set to audrasjb
- Status changed from new to assigned
Self assigning for commit.
3 years ago
#14
Committed in https://core.trac.wordpress.org/changeset/52267
Just curious if we want to get this into perhaps 5.8 as well, since it's such a minuscule change and shouldn't be breaking of anything that I can think of.