WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47959 closed enhancement (fixed)

'disable_formats_dropdown' filter does not pass no post_type.

Reported by: chrstffr's profile chrstffr Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: minor Version: 5.2
Component: Post Formats Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

On line 477 in class-wp-posts-list-table.php, the post type is not passed into the filter.

Attachments (2)

47959.patch​ (537 bytes) - added by MatheusFD 5 years ago.
Post type is now passed into the filter.
47959-2.diff​ (739 bytes) - added by birgire 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @mukesh27
5 years ago

  • Component changed from Posts, Post Types to Post Formats
  • Version changed from 5.2.2 to 5.2

#2 @SergeyBiryukov
5 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

@MatheusFD
5 years ago

Post type is now passed into the filter.

#3 @MatheusFD
5 years ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @davidbaumwald
5 years ago

  • Keywords commit added

@SergeyBiryukov The patch here looks good and still applies cleanly to trunk. Is this something that can be included for 5.3 Beta 1 tomorrow? If not, can we move this to a future milestone?

@birgire
5 years ago

#6 @birgire
5 years ago

Thanks for the patch @MatheusFD

47959-2.diff​ adds:

* @since 5.3.0 The `$post_type` parameter was added.

for the filter's changelog.

#7 @davidbaumwald
5 years ago

  • Milestone changed from 5.3 to Future Release

With 5.3 Beta 1 shipping today, I’m punting this to Future Release so as not to clog up the 5.4 milestone. However, @SergeyBiryukov, as the ticket owner feel free to move to 5.4 if you feel comfortable committing to resolving this fully during that release cycle. Thanks!

#8 @MatheusFD
5 years ago

Hey @SergeyBiryukov and @davidbaumwald,

Maybe we can deliver this patch in the next release?

#9 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.5

#10 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47472:

Post Formats: Pass post type to the disable_formats_dropdown filter in WP_Posts_List_Table::formats_dropdown().

Props MatheusFD, birgire.
Fixes #47959.

Note: See TracTickets for help on using tickets.