Missing strict comparison check in REST Autosaves Controller

[dkarfa]

Missing Yoda conditions check at wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php

[TimothyBlynJacobs]

Thanks for the patch @dkarfa!

I'm a bit worried about the $post->post_author === $user_id check. In the type doc it is listed as a string and accompanied by "A numeric string, for compatibility reasons."

[itowhid06]

I completely agree with @TimothyBlynJacobs about $post->post_author === $user_id check. Also the patch doesn't apply properly and I've refreshed it. I hope @dkarfa is OK with it :)

[TimothyBlynJacobs]

In other places this is used in core, a non-strict comparison check is used as well. For instance, wp_save_post_revision() or wp_create_post_autosave(). I think we'd want to be consistent, but I'm not sure.

Cc: @SergeyBiryukov

[TimothyBlynJacobs]

#49156 was marked as a duplicate.

[SergeyBiryukov]

In 47372:

Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.

Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.