WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47987, comment 39


Ignore:
Timestamp:
10/09/2019 07:56:28 PM (6 weeks ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47987, comment 39

    initial v1  
    44Yeah, would have been nice to add that but it needs to happen before "post processing" starts i.e. before the call to generate attachment meta.
    55
    6 Was also thinking the whole "create attachment + upload a file" flow may need another look. Generally "streaming" from js in the client seems to perform a lot worse than "direct" `multipart/form-data` request to the web server, both on the client side (large files may need to me fully loaded in memory) and on the server side (PHP may start "execution" as soon as the request starts, making it more likely to time out).
     6Was also thinking the whole "create attachment + upload a file" flow may need another look. Generally "streaming" from js in the client seems to perform a lot worse than "direct" `multipart/form-data` request to the web server, both on the client side (large files may need to me fully loaded in memory) and on the server side (PHP may start "execution" as soon as the request starts, counting the time it takes to transfer the file as "runtime" which makes it more likely to time out).