WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47987, comment 41


Ignore:
Timestamp:
10/13/2019 06:08:18 PM (4 weeks ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47987, comment 41

    initial v1  
    11Reopening to reevaluate the need for the `create-image-subsizes` action in `post_process_item()`.
    22
    3 This came up during implementing use of the end-point in https://github.com/WordPress/gutenberg/pull/17858. The purpose of the new end-point is allow post-processing of an uploaded file to continue after a fatal error. At this point the server "knows" what needs to be done, there is no point in limiting the action.
     3This came up during implementing use of the end-point in https://github.com/WordPress/gutenberg/pull/17858. removing `create-image-subsizes` would work well when the new end-point is used to allow post-processing of an uploaded file to continue after a fatal error. At this point the server "knows" what needs to be done, there is no point in limiting the action.
    44
    55The code there can be changed to test if the attachment is an image and if any sub-sizes are missing, then create the sub-sizes if necessary. In the future if post-processing is implemented for other file types, that can be added as well.