WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#47989 closed defect (bug) (fixed)

Must escape `%` in `printf`

Reported by: afragen Owned by: SergeyBiryukov
Priority: normal Milestone: 5.3
Component: Upgrade/Install Version:
Severity: major Keywords: needs-patch
Cc: Focuses:

Description

There's an error in r45926.

after() was changed to use a printf() statement, but the string must escape the % in width="100%" to be width="100%%".

Pinging @SergeyBiryukov

Change History (2)

#1 @SergeyBiryukov
7 years ago

  • Milestone Awaiting Review → 5.3

Great catch, thanks!

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 46072:

Upgrade/Install: Escape the % in width="100%" in a printf() call in Plugin_Upgrader_Skin::after().

Props afragen.
Fixes #47989.

Note: See TracTickets for help on using tickets.