WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48021, comment 2


Ignore:
Timestamp:
09/26/2019 01:03:05 PM (12 months ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48021, comment 2

    initial v1  
    55Noting that on other tickets related to the media views, for example in #47149, I'm proposing to make the `FocusManager` a more useful tool for general focus management methods to be reused across all the media views.
    66
    7 There are cases where focus needs to be managed also outside of the modal. For example in this case, when pressing the Dismiss error button, there's a focus loss that should be prevented. For the future, I'm considering to initialize `FocusManager` on the media frame so that it should be available everywhere.  For now, [attachment:"48021.diff"] should solves this specific error.
     7There are cases where focus needs to be managed also outside of the modal. For example in this case, when pressing the Dismiss error button, there's a focus loss that should be prevented. For the future, I'm considering to initialize `FocusManager` on the media frame so that it should be available everywhere.  For now, [attachment:"48021.diff"] should solve this specific error.
    88
    99Setting the milestone to 5.2.4 as it's a small, self-contained fix. Please do feel free to change it if not appropriate.