HTML5 input types are not being reset when submitting the addtag form

[stevegrunwell]

The addtag form on wp-admin/edit-tags.php automatically clears the new term's name, slug, and description field but will *not* clear any visible inputs beyond input[type="text"] and textarea.

The offending bit of code is in js/_enqueues/admin/tags.js:

$('input[type="text"]:visible, textarea:visible', form).val('');

If we broaden the scope a bit, we can hit all visible inputs but still exclude checkboxes + radios.

[stevegrunwell]

Updated version that excludes radio buttons and checkboxes.

[davidbaumwald]

In 52953:

Taxonomy: Consider HTML5 input types when resetting form values after adding a new tag.

When adding a new tag, the form is reset by clearing values for input[type=text] and textareas. However, the reset doesn't account for any HTML5 input types, like number or url, that may be added by plugins or themes.

This change updates the form resetting jQuery to clear any values from input types that are not hidden and neither a checkbox nor radio type.

Props stevegrunwell.
Fixes #48030.

[peterwilsoncc]

The selector is a little eager and removes the text from the submit button too. I've added a gif above to illustrate.

I suggest

• include the parent div.form-field > in the selector
• exclude button types, including submit, reset, etc.

[davidbaumwald]

Per discussion with @peterwilsoncc, including the parent in the selector would force plugins/themes to follow the same pattern to take advantage of the form reset on submission. As there's currently many plugins making use of this feature, the safe thing to do here is to omit the parent selector.

However, the buttons do need to be accounted for. Updated patch incoming. Would appreciate some additional testing to make sure we've covered the default fields while also allowing for extenders to use the feature with their added fields/buttons.

[davidbaumwald]

Updated patch excluding buttons types

[davidbaumwald]

In 53168:

Taxonomy: Only reset non-button form field values after adding a tag.

[52953] added HTML5 input types to the form reset after a tag is created. The selector was a bit too greedy, causing button types to have their values reset also.

This change updates the jQuery selector to exclude button, submit, and reset input types from the form reset.

Follow-up to [52953].

Props peterwilsoncc.
Fixes #48030.