WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 8 weeks ago

Last modified 5 weeks ago

#48031 closed enhancement (fixed)

Update Masonry

Reported by: desrosj Owned by: SergeyBiryukov
Milestone: 5.5 Priority: low
Severity: minor Version:
Component: External Libraries Keywords: has-patch needs-testing has-dev-note
Focuses: javascript Cc:

Description

The masonry-layout package is outdated. Version 3.3.2 is currently packaged. The current version is 4.2.2.

The most notable change when updating this library is that support for IE 8 & 9 would be dropped in Masonry. WordPress Core currently only supports IE 11 and Edge, so this is OK. But, a dev note should probably be published to get the word out in case sites need to support older versions of IE on the front end.

Release Notes: https://github.com/desandro/masonry/releases
Version Comparison: https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2

Attachments (3)

48031.patch (1.4 KB) - added by pierlo 11 months ago.
Upgrade Masonry to v4.2.2
48031.2.patch (9.5 KB) - added by pierlo 11 months ago.
Include package-lock.json
48031.3.diff (5.6 KB) - added by Hareesh Pillai 8 weeks ago.
Patch refreshed

Download all attachments as: .zip

Change History (14)

@pierlo
11 months ago

Upgrade Masonry to v4.2.2

#1 @pierlo
11 months ago

  • Keywords has-patch needs-dev-note added; needs-patch removed

Thanks for the report @desrosj.

This ticket was mentioned in Slack in #core by pierlo. View the logs.


11 months ago

@pierlo
11 months ago

Include package-lock.json

#3 @garrett-eclipse
11 months ago

Hi @pierlo reviewing 48031.2.patch quickly there's alot of potentially unintended changes as I'm seeing several scripts removed that aren't related to masonry;
desandro-get-style-property-1.0.4.tgz
doc-ready-1.0.4.tgz

As well as some others added;
ev-emitter-1.1.1.tgz

I may be wrong but I believe you want to make sure your patch only updates masonry.

#4 follow-up: @pierlo
11 months ago

Thanks for the review, @garrett-eclipse. Those changes are apart of the dependencies for masonry.

masonry-layout@4.2.2, required by WordPress@5.3.0
get-size@2.0.3, required by masonry-layout@4.2.2
outlayer@2.1.1, required by masonry-layout@4.2.2
ev-emitter@1.1.1, required by outlayer@2.1.1
fizzy-ui-utils@2.0.7, required by outlayer@2.1.1
get-size@2.0.3, required by outlayer@2.1.1
desandro-matches-selector@2.0.2, required by fizzy-ui-utils@2.0.7

Last edited 11 months ago by pierlo (previous) (diff)

#5 in reply to: ↑ 4 @garrett-eclipse
11 months ago

  • Keywords needs-testing added

Replying to pierlo:

Thanks for the review, @garrett-eclipse. Those changes are apart of the dependencies for masonry.

masonry-layout@4.2.2, required by WordPress@5.3.0
get-size@2.0.3, required by masonry-layout@4.2.2
outlayer@2.1.1, required by masonry-layout@4.2.2
ev-emitter@1.1.1, required by outlayer@2.1.1
fizzy-ui-utils@2.0.7, required by outlayer@2.1.1
get-size@2.0.3, required by outlayer@2.1.1
desandro-matches-selector@2.0.2, required by fizzy-ui-utils@2.0.7

AHH nice that makes sense, thanks for the explaination @pierlo I'll leave to @desrosj or @SergeyBiryukov to review more thoroughly and test.

#6 @chesio
11 months ago

Please, note that there's already ticket for that: #44780 It has no patch yet though, so I'm not sure which of the two should be marked as duplicate.

#7 @desrosj
11 months ago

#44780 was marked as a duplicate.

@Hareesh Pillai
8 weeks ago

Patch refreshed

#9 @SergeyBiryukov
8 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48038:

External Libraries: Update Masonry to 4.2.2 and imagesLoaded to 4.1.4.

Notable changes include dropping support for IE 8 & 9, which are no longer supported by WordPress core either.

Release notes:
https://github.com/desandro/masonry/releases
https://github.com/desandro/imagesloaded/releases

Changelogs:
https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
https://github.com/desandro/imagesloaded/compare/v3.2.0...v4.1.4

Props pierlo, hareesh-pillai, grapplerulrich, pderksen, desrosj, garrett-eclipse, SergeyBiryukov.
Fixes #37675, #48031.

#10 @SergeyBiryukov
8 weeks ago

  • Milestone changed from Awaiting Review to 5.5

#11 @desrosj
5 weeks ago

  • Keywords has-dev-note added; needs-dev-note removed
Note: See TracTickets for help on using tickets.