#48031 closed enhancement (fixed)
Update Masonry
Reported by: | desrosj | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5 | Priority: | low |
Severity: | minor | Version: | |
Component: | External Libraries | Keywords: | has-patch needs-testing has-dev-note |
Focuses: | javascript | Cc: |
Description
The masonry-layout
package is outdated. Version 3.3.2 is currently packaged. The current version is 4.2.2.
The most notable change when updating this library is that support for IE 8 & 9 would be dropped in Masonry. WordPress Core currently only supports IE 11 and Edge, so this is OK. But, a dev note should probably be published to get the word out in case sites need to support older versions of IE on the front end.
Release Notes: https://github.com/desandro/masonry/releases
Version Comparison: https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
Attachments (3)
Change History (14)
#1
@
5 years ago
- Keywords has-patch needs-dev-note added; needs-patch removed
Thanks for the report @desrosj.
This ticket was mentioned in Slack in #core by pierlo. View the logs.
5 years ago
#3
@
5 years ago
Hi @pierlo reviewing 48031.2.patch quickly there's alot of potentially unintended changes as I'm seeing several scripts removed that aren't related to masonry;
desandro-get-style-property-1.0.4.tgz
doc-ready-1.0.4.tgz
As well as some others added;
ev-emitter-1.1.1.tgz
I may be wrong but I believe you want to make sure your patch only updates masonry.
#4
follow-up:
↓ 5
@
5 years ago
Thanks for the review, @garrett-eclipse. Those changes are apart of the dependencies for masonry
.
#5
in reply to:
↑ 4
@
5 years ago
- Keywords needs-testing added
Replying to pierlo:
Thanks for the review, @garrett-eclipse. Those changes are apart of the dependencies for
masonry
.
masonry-layout@4.2.2, required by WordPress@5.3.0
get-size@2.0.3, required by masonry-layout@4.2.2
outlayer@2.1.1, required by masonry-layout@4.2.2
ev-emitter@1.1.1, required by outlayer@2.1.1
fizzy-ui-utils@2.0.7, required by outlayer@2.1.1
get-size@2.0.3, required by outlayer@2.1.1
desandro-matches-selector@2.0.2, required by fizzy-ui-utils@2.0.7
AHH nice that makes sense, thanks for the explaination @pierlo I'll leave to @desrosj or @SergeyBiryukov to review more thoroughly and test.
#6
@
5 years ago
Please, note that there's already ticket for that: #44780 It has no patch yet though, so I'm not sure which of the two should be marked as duplicate.
#9
@
4 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 48038:
#11
@
4 years ago
- Keywords has-dev-note added; needs-dev-note removed
This was noted in the following dev note: https://make.wordpress.org/core/2020/07/01/external-library-updates-in-wordpress-5-5-call-for-testing/
Upgrade Masonry to v4.2.2