Opened 5 years ago
Last modified 4 years ago
#48054 new enhancement
wp.sanitize.stripTags should iterate instead of using recursion
Reported by: | jrchamp | Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | minor | Version: | 5.2.3 |
Component: | General | Keywords: | has-patch needs-testing |
Focuses: | javascript, performance | Cc: |
Description
The changes to wp-sanitize.js seemed wasteful and like it produced dead code in the final return.
When I got into it to fix the dead code, I also felt a way about the recursion, because stack and memory exhaustion are two other potential issues. So this way should *at most* be one function call and only duplicate memory instead of being O(n*memory).
https://github.com/WordPress/WordPress/commit/d9b128f50546a65c9cf0944ee61237e35ff269c0
This is probably a drive-by commit and for that I apologize. I hope it's more useful than not, but your mileage may vary. Thank you for making WordPress.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
applying changes to /js/_enqueues/wp/sanitize.js