WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 13 days ago

#48054 new enhancement

wp.sanitize.stripTags should iterate instead of using recursion

Reported by: jrchamp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 5.2.3
Component: General Keywords: has-patch needs-testing
Focuses: javascript, performance Cc:

Description

The changes to wp-sanitize.js seemed wasteful and like it produced dead code in the final return.

https://github.com/WordPress/WordPress/commit/90d9bdc54c82229b3aa5a6e60d775f14b1f9a9dc#diff-9bedaa5d6abc6cb127b2f496bb2f7835

When I got into it to fix the dead code, I also felt a way about the recursion, because stack and memory exhaustion are two other potential issues. So this way should *at most* be one function call and only duplicate memory instead of being O(n*memory).

https://github.com/WordPress/WordPress/commit/d9b128f50546a65c9cf0944ee61237e35ff269c0

This is probably a drive-by commit and for that I apologize. I hope it's more useful than not, but your mileage may vary. Thank you for making WordPress.

Attachments (1)

48054.patch (1.2 KB) - added by sabernhardt 2 weeks ago.
applying changes to /js/_enqueues/wp/sanitize.js

Download all attachments as: .zip

Change History (3)

@sabernhardt
2 weeks ago

applying changes to /js/_enqueues/wp/sanitize.js

#1 @sabernhardt
2 weeks ago

  • Focuses javascript performance added
  • Keywords needs-testing added

@jrchamp Thanks for the patch!

I simply moved those changes to the file that creates wp-includes/js/wp-sanitize.js.

#2 @jrchamp
13 days ago

Thanks @sabernhardt!

Note: See TracTickets for help on using tickets.