WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#48067 closed defect (bug) (fixed)

Audio details Underscore Template: What is a "caca URL" ?

Reported by: imath's profile imath Owned by: audrasjb's profile audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Hi,

I've just noticed the Audio details underscore template was using a weird label for the Audio source URL since [45499].

In french "caca" means poop so I'm a bit surprised and I'm wondering if it's a typo error. I've search some relative audio things to "caca" and couldn't find any.

Just in case it was a typo, I'm attaching a patch to replace this word by "Audio source URL".

Attachments (1)

48067.patch​ (717 bytes) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (7)

@imath
6 years ago

#1 @audrasjb
6 years ago

  • Milestone changed from Awaiting Review to 5.3
  • Version trunk deleted

Definitely something to fix as soon as possible.
Thanks for the patch @imath !

#2 @audrasjb
6 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#3 @audrasjb
6 years ago

  • Keywords commit added

I tested the patch: it applies cleanly and it fixes that "caca URL" issue.

That was clearly a typo introduced in changeset [45499] (For reference: ticket #47141).

I think it's ready to go. Adding commit keyword.

#4 @afercia
6 years ago

Thanks @imath! Will restore to the original string URL :D

#5 @afercia
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46168:

Media: remove leftover test string change after [45499].

Props imath, audrasjb.
Fixes #48067.

#6 @afercia
6 years ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.