Can't install plugins on trunk due to 'Cannot read property speak of undefined'

[garrett-eclipse]

Hello,

On a clean install of trunk I'm no longer able to install plugins due to a11y speak property not defined.

The error is related to this line;
​https://github.com/WordPress/wordpress-develop/blob/c957e2573e7911c772ec85eb9f339ee34a9fd470/src/js/_enqueues/wp/updates.js#L563
*But I assume affects all speak commands in the script.

Error in js console;

Uncaught TypeError: Cannot read property 'speak' of undefined
    at Object.b.updates.installPlugin (load-scripts.php?c=1&load[chunk_0]=hoverIntent,common,admin-bar,jquery-ui-core,thickbox,plugin-install,underscore,wp-util,wp-sanitize,wp-a11y,updates,svg-painter&ver=5.3-alpha-20190919.002339:359)
    at HTMLAnchorElement.<anonymous> (load-scripts.php?c=1&load[chunk_0]=hoverIntent,common,admin-bar,jquery-ui-core,thickbox,plugin-install,underscore,wp-util,wp-sanitize,wp-a11y,updates,svg-painter&ver=5.3-alpha-20190919.002339:359)
    at HTMLFormElement.dispatch (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.3-alpha-20190919.002339:3)
    at HTMLFormElement.r.handle (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.3-alpha-20190919.002339:3)
b.updates.installPlugin @ load-scripts.php?c=1&load[chunk_0]=hoverIntent,common,admin-bar,jquery-ui-core,thickbox,plugin-install,underscore,wp-util,wp-sanitize,wp-a11y,updates,svg-painter&ver=5.3-alpha-20190919.002339:359
(anonymous) @ load-scripts.php?c=1&load[chunk_0]=hoverIntent,common,admin-bar,jquery-ui-core,thickbox,plugin-install,underscore,wp-util,wp-sanitize,wp-a11y,updates,svg-painter&ver=5.3-alpha-20190919.002339:359
dispatch @ load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.3-alpha-20190919.002339:3
r.handle @ load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.3-alpha-20190919.002339:3
00:39:55.057 

I believe this is related to the commit today - [46169]
Related Ticket - #45066

[garrett-eclipse]

Install is stuck on the ajax-loader gif

[sstoqnov]

Remove wp-a11y from script-loader.php

[sstoqnov]

The wp-a11y script is still loaded in wp-includes/script-loader.php.

In [46167] and [46169] this change is not merged, but it exists in https://core.trac.wordpress.org/attachment/ticket/45066/45066.8.diff

It's my fault. Sorry for the mess with these gazillion patches

[garrett-eclipse]

Thanks @sstoqnov testing the patch it fixed the issue on the install boxes. But on the popup modal for More Details the Install Now doesn't seem to trigger. Creating screen

[garrett-eclipse]

Illustrating remaining issue with install on popup. Note: no error in js console for this issue.

[afercia]

@garrett-eclipse "Install now" from the modal works for me. Can you try npm install && grunt build after applying the patch?

[sstoqnov]

It works for me too

[garrett-eclipse]

Thanks for your patience @afercia & @sstoqnov took me some time to sort that. I'm running MAMP on 8888 so my URL was localhost:8888/48071 and apparently the _parent frameception that goes into the modal install doesn't fly on localhost. I bundled up my install and moved it to a server and everything worked as expected.

The patch looks good to commit.

Is the issue with installing plugins on localhost (MAMP) worth another ticket (one less major)?

[afercia]

@garrett-eclipse not an expert but it may be because of browsers restrictions? Not sure the plugin details modal is supposed to work from localhost because of the iframe?

Going to commit this.

[afercia]

In 46179:

Script Loader: Remove old wp-a11y from the loaded scripts after [46167] and [46169].

Props garrett-eclipse, sstoqnov.
See #45066.
Fixes #48071.

[SergeyBiryukov]

In 46180:

Tests: Update unit tests to account for the removal of old wp-a11y from the loaded scripts in [46179].

Props sstoqnov.
See #45066, #48071.

[garrett-eclipse]

Thanks @afercia / @sstoqnov / @SergeyBiryukov I appreciate you all jumping on this to resolve.

Replying to afercia:

@garrett-eclipse not an expert but it may be because of browsers restrictions? Not sure the plugin details modal is supposed to work from localhost because of the iframe?

Appreciated, I'm not too concerned now that I'm aware but added #48077 to make it known and maybe someone knows how those limitations work.