Changes between Initial Version and Version 1 of Ticket #48082, comment 1
- Timestamp:
- 09/19/2019 11:58:04 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48082, comment 1
initial v1 4 4 1. In a lot of places the patch does not comply with the coding standards regarding whitespace on the inside of parentheses. Please run `composer format` over the patch to fix this. 5 5 2. As nearly all of these touch `include/require` statements, may this be a good time to remove the unnecessary parentheses which are often used with them ? 6 `include`/`require` are language constructs, not function calls and not using the parentheses has an - albeit arginal - performance benefit.6 `include`/`require` are language constructs, not function calls and not using the parentheses has an - albeit marginal - performance benefit. 7 7 8 8 {{{#!php