Make WordPress Core

Opened 6 years ago

Closed 3 months ago

#48085 closed defect (bug) (wontfix)

use wp_safe_redirect() function

Reported by: dkarfa's profile dkarfa Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch close
Focuses: Cc:

Description


Attachments (1)

48085.patch (1.3 KB) - added by dkarfa 6 years ago.

Download all attachments as: .zip

Change History (3)

@dkarfa
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Keywords close added

Thanks for the patch! It would be helpful to describe what problem it solves though :)

Looking at other instances of wp_safe_redirect() in the admin, it's only used in combination with wp_get_referer() to validate the target location sent by the client's browser.

I don't see a point in using it when the location is a known admin URL.

#2 @karmatosed
3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thank you for your ticket and patch. For now, I am closing it as the recommendation has been to close based on the feedback, along with the time passed and the stale state of the patch. If you still would like to implement this, please respond with an updated patch and details, and then we can reopen.

Note: See TracTickets for help on using tickets.