Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48096 closed defect (bug) (fixed)

Fixed docblock in `cache_add` method in `WP_Theme` class

Reported by: itowhid06's profile itowhid06 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: docs Cc:


$data @param type of $data in cache_add method in WP_Theme class because in several instances array is being passed as $data

Attachments (2)

48096.diff (563 bytes) - added by itowhid06 5 years ago.
48096.1.diff (570 bytes) - added by itowhid06 5 years ago.

Download all attachments as: .zip

Change History (6)

5 years ago

#1 @williampatton
5 years ago

Hey @itowhid06, thank you for the patch!

If you have looked to see that sometimes array is passed to this did you consider if it would be more useful to use string|array instead of mixed?

#2 @itowhid06
5 years ago

@williampatton, you are right. I've updated the patch(48096.1.diff).

5 years ago

#3 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46226:

Docs: Correct type for the $data parameter of WP_Theme::cache_add().

Props itowhid06.
Fixes #48096.

Note: See TracTickets for help on using tickets.