WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 12 months ago

#48110 closed task (blessed) (fixed)

Import Twenty Twenty

Reported by: ianbelanger Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

This is the reference ticket for the Twenty Twenty theme which is currently under development, ready for 5.3.

Initial development happened on GitHub: https://github.com/WordPress/twentytwenty

Read the announcement post: https://make.wordpress.org/core/2019/09/06/introducing-twenty-twenty/

Attachments (15)

48110.diff (1.6 MB) - added by desrosj 2 years ago.
48110.2.diff (1.6 MB) - added by desrosj 2 years ago.
48110.3.diff (1.6 MB) - added by desrosj 2 years ago.
48110-default-theme-bump.diff (5.7 KB) - added by desrosj 2 years ago.
48110.4.diff (1.8 MB) - added by ianbelanger 2 years ago.
Beta 2 build of Twenty Twenty
48110.5.diff (1.8 MB) - added by desrosj 2 years ago.
48110.6.diff (1.8 MB) - added by desrosj 2 years ago.
Updated Twenty Twenty patch.
48110.8.diff (249.5 KB) - added by williampatton 2 years ago.
48110.9.diff (272.2 KB) - added by williampatton 2 years ago.
48110.10.diff (1.9 MB) - added by ianbelanger 2 years ago.
Attempt at diff for beta 3
48110.11.diff (265.3 KB) - added by ianbelanger 2 years ago.
another beta 3 try
48110.12.diff (1.9 MB) - added by azaozz 2 years ago.
48110-beta-3.diff (266.1 KB) - added by desrosj 2 years ago.
48110-fix-jshint-error.diff (579 bytes) - added by ianbelanger 2 years ago.
Fixes the jshint error
48110.rc-1.diff (26.4 KB) - added by ianbelanger 2 years ago.
Release Candidate 1 Twenty Twenty patch

Change History (52)

@desrosj
2 years ago

#1 @desrosj
2 years ago

  • Keywords has-patch needs-testing added

Working through creating a patch for this with @ianbelanger.

48110.diff is a first pass at the patch for merging Twenty Twenty.

This patch does not copy over the composer.json and composer.lock files, license.txt, or README.md files. This was based on what I saw included in past default themes, though. We can include these if that is desired.

This ticket was mentioned in Slack in #core-themes by desrosj. View the logs.


2 years ago

@desrosj
2 years ago

#3 @desrosj
2 years ago

48110.2.diff contains some WordPress Core coding standards fixes and adds the screenshot (which was missed in the first patch).

One thing to note, if a node_modules folder is present in the theme, grunt build will take a very long time because it is copying the entire folder. A quick remedy for this is to remove the theme's node_modules folder before running grunt build. This can be fixed after beta 1.

@desrosj
2 years ago

#4 @desrosj
2 years ago

48110.3.diff includes some font files missed in the original patches.

#5 @ianbelanger
2 years ago

  • Keywords commit added

#6 @desrosj
2 years ago

In 46271:

Bundled Themes: Import Twenty Twenty, the new default theme for WordPress 5.3.

Welcome to the bundled themes family!

Theme development to this point has taken place on GitHub. See: https://github.com/WordPress/twentytwenty/.

Props anlino, ianbelanger, audrasjb, nielslange, fabiankaegy, mukesh27, poena, joyously, emiluzelac, williampatton, dingo-d, dkarfa, acosmin, rabmalin, kafleg, jeffpaul, hareesh-pillai, burhandodhy, afercia, juanfra, soean, presskopp, justinahinon, jrf, netweb, garyj, pento, flixos90, vbaimas, zebulan, byalextran, mor10, kjellr, allancole, tdh, karmatosed, mapk, matt, andrewtaylor-1, ismailelkorchi, garrett-eclipse, gsayed786, dianeco, celloexpressions, aristath, nadir, cbravobernal, intimez, hometowntrailers, collet, littlebigthing, tobifjellner, kevinkovadia, jarretc.
See #48110.

#7 @ianbelanger
2 years ago

  • Keywords needs-testing removed

#8 @desrosj
2 years ago

In 46277:

Bundled Themes: Fix failing tests for Twenty Twenty.

Follow up of [46271].

See #48110.

#9 @desrosj
2 years ago

48110-default-theme-bump.diff updates the default theme for new installs to Twenty Twenty.

#10 @ocean90
2 years ago

Tested 48110-default-theme-bump.diff on a fresh install, Twenty Twenty was enabled as expected. 👍

#11 @desrosj
2 years ago

In 46278:

Bundled Themes: Make Twenty Twenty the new default theme.

After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.

See #48110.
Props desrosj, ocean90.

#12 @desrosj
2 years ago

  • Summary changed from Twenty Twenty to Import Twenty Twenty
  • Type changed from enhancement to task (blessed)

Going to convert this to a task so that updates can continue to be synced as necessary.

#13 @SergeyBiryukov
2 years ago

In 46282:

Tests: Correct sidebar names for Twenty Twenty.

See #48110.

#14 @SergeyBiryukov
2 years ago

In 46283:

Twenty Twenty: Rename widget areas to sidebar-1 and sidebar-2.

This ensures that widgets are mapped correctly and is consistent with the previous default themes.

See https://github.com/WordPress/twentytwenty/issues/481.

Reverts [46282].

Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110.

#15 @SergeyBiryukov
2 years ago

In 46284:

Coding Standards: Fix WPCS issue in [46283].

See #48110.

@ianbelanger
2 years ago

Beta 2 build of Twenty Twenty

@desrosj
2 years ago

#16 @desrosj
2 years ago

  • Keywords needs-testing added; commit removed

48110.5.diff re-adds a jshint inline ignore.

Also, here is a test build: https://travis-ci.org/desrosj/wordpress-develop/builds/590603098. There is a failing JS test. in the most recent patch.

#17 @desrosj
2 years ago

In 46352:

Built/Test Tools: Ignore the node_modules folder in Twenty Twenty.

Ignore the node_modules folder in Twenty Twenty in SVN, and when running grunt build or grunt jshint:themes.

See #48110.

@desrosj
2 years ago

Updated Twenty Twenty patch.

This ticket was mentioned in Slack in #core by ianbelanger. View the logs.


2 years ago

#19 @desrosj
2 years ago

In 46357:

Bundled Themes: Update Twenty Twenty.

This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46271], see https://github.com/WordPress/twentytwenty/compare/932b16248...dd7032f

Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110.

#20 @ianbelanger
2 years ago

  • Keywords commit added

#48110.6.diff looks good @desrosj. All changes to Twenty Twenty as of September 30th, 16:00 UTC are included in this patch.

The last commit included was https://github.com/WordPress/twentytwenty/commit/dd7032f2d7bca319eafb1aa602130d24d8ec489c

@ianbelanger
2 years ago

Attempt at diff for beta 3

@ianbelanger
2 years ago

another beta 3 try

@azaozz
2 years ago

@desrosj
2 years ago

#21 @desrosj
2 years ago

Worked through some issues creating a patch with @ianbelanger and @azaozz in Slack. 48110-beta-3.diff is the one that should land. The text files also need to be updated to svn:eol-style=native, which I'll handle as well.

#22 @desrosj
2 years ago

In 46445:

Bundled Themes: Update Twenty Twenty.

This brings trunk's version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see https://github.com/WordPress/twentytwenty/compare/7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.

Last edited 2 years ago by ianbelanger (previous) (diff)

#23 @desrosj
2 years ago

In 46446:

Bundled Themes: Change the eol-style property to native for Twenty Twenty files.

Props aazaozz, desrosj.
See #48110.

@ianbelanger
2 years ago

Fixes the jshint error

#24 @ocean90
2 years ago

In 46447:

Bundled Themes: Fix JSHint error in [46445]

Props ianbelanger.
See #48110.

@ianbelanger
2 years ago

Release Candidate 1 Twenty Twenty patch

#25 @desrosj
2 years ago

In 46551:

Bundled Themes: Update Twenty Twenty.

This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see https://github.com/WordPress/twentytwenty/compare/7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.

#26 @desrosj
2 years ago

  • Keywords needs-testing commit removed
  • Resolution set to fixed
  • Status changed from new to closed

With RC1 today, I'm going to close this out.

This ticket can be reopened when further changes need to be synced during this cycle.

Please continue to report bugs on the GitHub repository. After 5.3 is released, the repo can be placed into read-only mode and remaining issues can be ported to Trac.

#27 @desrosj
2 years ago

In 46668:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see https://github.com/WordPress/twentytwenty/compare/dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

#28 @desrosj
2 years ago

In 46669:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see https://github.com/WordPress/twentytwenty/compare/dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

#29 @SergeyBiryukov
2 years ago

In 46701:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#30 @SergeyBiryukov
2 years ago

In 46712:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.

#31 @SergeyBiryukov
2 years ago

In 46713:

Bundled Themes: Update Twenty Twenty.

  • Add a11y-friendly default text-colors when selecting a background-color.
  • Remove margins for the group block when a background-color is set.
  • Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#32 @SergeyBiryukov
2 years ago

In 46714:

Bundled Themes: Update Twenty Twenty.

  • Add a11y-friendly default text-colors when selecting a background-color.
  • Remove margins for the group block when a background-color is set.
  • Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.

#33 @SergeyBiryukov
2 years ago

In 46715:

Bundled Themes: Update Twenty Twenty.

  • Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

#34 @SergeyBiryukov
2 years ago

In 46716:

Bundled Themes: Update Twenty Twenty.

  • Add .has-background excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.

#35 @SergeyBiryukov
2 years ago

In 46722:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.

#36 @SergeyBiryukov
2 years ago

In 46723:

Bundled Themes: Update Twenty Twenty.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.

#37 @desrosj
12 months ago

In 49220:

Bundled Themes: Make Twenty Twenty-One the default theme.

After being imported in [49216], Twenty Twenty-One can now be set as the default theme in WordPress.

See #48110.

Note: See TracTickets for help on using tickets.