#48110 closed task (blessed) (fixed)
Import Twenty Twenty
Reported by: | ianbelanger | Owned by: | |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
This is the reference ticket for the Twenty Twenty theme which is currently under development, ready for 5.3.
Initial development happened on GitHub: https://github.com/WordPress/twentytwenty
Read the announcement post: https://make.wordpress.org/core/2019/09/06/introducing-twenty-twenty/
Attachments (15)
Change History (52)
This ticket was mentioned in Slack in #core-themes by desrosj. View the logs.
5 years ago
#3
@
5 years ago
48110.2.diff contains some WordPress Core coding standards fixes and adds the screenshot (which was missed in the first patch).
One thing to note, if a node_modules
folder is present in the theme, grunt build
will take a very long time because it is copying the entire folder. A quick remedy for this is to remove the theme's node_modules
folder before running grunt build
. This can be fixed after beta 1.
#4
@
5 years ago
48110.3.diff includes some font files missed in the original patches.
#9
@
5 years ago
48110-default-theme-bump.diff updates the default theme for new installs to Twenty Twenty.
#10
@
5 years ago
Tested 48110-default-theme-bump.diff on a fresh install, Twenty Twenty was enabled as expected. 👍
#12
@
5 years ago
- Summary changed from Twenty Twenty to Import Twenty Twenty
- Type changed from enhancement to task (blessed)
Going to convert this to a task so that updates can continue to be synced as necessary.
#16
@
5 years ago
- Keywords needs-testing added; commit removed
48110.5.diff re-adds a jshint
inline ignore.
Also, here is a test build: https://travis-ci.org/desrosj/wordpress-develop/builds/590603098. There is a failing JS test. in the most recent patch.
This ticket was mentioned in Slack in #core by ianbelanger. View the logs.
5 years ago
#20
@
5 years ago
- Keywords commit added
#48110.6.diff looks good @desrosj. All changes to Twenty Twenty
as of September 30th, 16:00 UTC are included in this patch.
The last commit included was https://github.com/WordPress/twentytwenty/commit/dd7032f2d7bca319eafb1aa602130d24d8ec489c
#21
@
5 years ago
Worked through some issues creating a patch with @ianbelanger and @azaozz in Slack. 48110-beta-3.diff is the one that should land. The text files also need to be updated to svn:eol-style=native
, which I'll handle as well.
#26
@
5 years ago
- Keywords needs-testing commit removed
- Resolution set to fixed
- Status changed from new to closed
With RC1 today, I'm going to close this out.
This ticket can be reopened when further changes need to be synced during this cycle.
Please continue to report bugs on the GitHub repository. After 5.3 is released, the repo can be placed into read-only mode and remaining issues can be ported to Trac.
Working through creating a patch for this with @ianbelanger.
48110.diff is a first pass at the patch for merging Twenty Twenty.
This patch does not copy over the
composer.json
andcomposer.lock
files,license.txt
, orREADME.md
files. This was based on what I saw included in past default themes, though. We can include these if that is desired.