WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#48112 closed defect (bug) (fixed)

Undefined $type_attr for TwentyTwenty When A Custom Background is Set

Reported by: davidbaumwald's profile davidbaumwald Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

[46164] introduced a type attribute one the inline <style> tag when a custom background is defined in the Customizer. This produces a notice:

Notice: Undefined variable: type_attr in wp-includes\theme.php on line 1708

The notice is thrown inline in the render, making the <style> tag malformed and not used.

The attached patch moves the $type_attr assignment out of the conditional which is only evaluated in certain themes.

Attachments (1)

48112.diff​ (651 bytes) - added by davidbaumwald 5 years ago.
Patch

Download all attachments as: .zip

Change History (6)

@davidbaumwald
5 years ago

Patch

#1 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
  • Summary changed from Undefinred $type_attr for TwentyTwenty When A Custom Background is Set to Undefined $type_attr for TwentyTwenty When A Custom Background is Set

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46270:

Themes: After [46164], make sure $type_attr is always defined in _custom_background_cb().

Props davidbaumwald.
Fixes #48112.

This ticket was mentioned in ​Slack in #core-themes by desrosj. ​View the logs.
5 years ago

#5 @SergeyBiryukov
5 years ago

#48107 was marked as a duplicate.

Note: See TracTickets for help on using tickets.