WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #48154, comment 67


Ignore:
Timestamp:
02/29/2020 12:39:55 AM (12 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48154, comment 67

    v1 v2  
    77@dd32 @762e5e74 what would be the best way to fix this? Looking at Grunt, it cleans (empties) the /build dir every time before copying the files on every build, but that doesn't seem to work in the build repo. Shall I try to revert then delete these files directly in the build repo or is there a better way to do this?
    88
    9 Looking at why this happened: `script-loader-packages.php` is slightly different depending on whether Webpack was run for "build" or "dev" mode. My theory is that:
     9Looking at why this happened: `script-loader-packages.php` is slightly different depending on whether Webpack was run in "build" or "dev" mode. My theory is that:
    1010- `/src/wp-includes/assets/script-loader-packages.php` was different than what's in the build repo.
    1111- After copying the WP files (which happens first when building) there were uncommitted changes in that file.