Context Navigation

← Previous Ticket
Next Ticket →

#48155 closed enhancement (fixed)

Different capitalisation in assertArrayhasKey method call

Reported by:	david.binda	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.3
Component:	REST API	Version:
Severity:	trivial	Keywords:	has-patch
Cc:		Focuses:

Description

The r46252 introduced assertArrayhasKey method call, which is capitalised differently than then rest of the calls in the same method.

157                     $this->assertArrayHasKey( 'name', $properties );
158                     $this->assertArrayHasKey( 'private', $properties );
159                     $this->assertArrayHasKey( 'protected', $properties );
160                     $this->assertArrayHasKey( 'public', $properties );
161                     $this->assertArrayHasKey( 'queryable', $properties );
162                     $this->assertArrayHasKey( 'show_in_list', $properties );
163                     $this->assertArrayHasKey( 'slug', $properties );
164                     $this->assertArrayhasKey( 'date_floating', $properties );

Note the lower-case "h" in "has" on line 164, vs. capital H on the other lines. This is, obviously, not breaking anything as function names in PHP are case-insensitive, it just makes the code less readable.

Attachments (1)

48155.patch (682 bytes ) - added by dkarfa 7 years ago.

Download all attachments as: .zip

Change History (5)

@dkarfa
7 years ago

Attachment 48155.patch added

#1 @dkarfa
7 years ago

Keywords has-patch added
Resolution → invalid
Status new → closed

#2 @johnbillion
7 years ago

Component General → REST API
Resolution invalid
Status closed → reopened

#3 @SergeyBiryukov
7 years ago

Milestone Awaiting Review → 5.3

#4 @SergeyBiryukov
7 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status reopened → closed

In 46329:

Tests: Correct ::assertArrayHasKey() capitalization in [46252].

Props dkarfa, david.binda.
Fixes #48155.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core