WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#48177 closed defect (bug) (wontfix)

Remove deprecated get_all_category_ids() from Tests

Reported by: dkarfa's profile dkarfa Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description


Attachments (1)

48177.patch​ (844 bytes) - added by dkarfa 4 years ago.
Patch

Download all attachments as: .zip

Change History (5)

@dkarfa
4 years ago

Patch

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Taxonomy
  • Keywords close added

Thanks for the patch!

Even if the function is deprecated, as long as it's still in core, we need tests to ensure it works correctly. I'd say that having tests for deprecated functions is especially important for tracking any accidental regressions, as the functions are not used otherwise. I don't see why this test should be removed.

#3 @dkarfa
4 years ago

Hi @SergeyBiryukov
Thanks for the update, as you see the test function using get_all_category_ids(), which is deprecated.
Regards,

#4 @SergeyBiryukov
4 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing, per comment:1.

Note: See TracTickets for help on using tickets.