WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#48178 closed enhancement (fixed)

Unused global $wpdb in WP_Privacy_Requests_Table::prepare_items

Reported by: davidbinda's profile david.binda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version: 5.0
Component: Privacy Keywords:
Focuses: Cc:

Description

The global $wpdb variable in WP_Privacy_Requests_Table::prepare_items is not being used. It has actually never been used inside the method. It should be safe to remove it.

Attachments (1)

48178.diff​ (574 bytes) - added by david.binda 6 years ago.

Download all attachments as: .zip

Change History (4)

@david.binda
6 years ago

#1 @jrf
6 years ago

LGTM. The function uses a new WP_Query instance, not $wpdb.

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46374:

Privacy: Remove unused $wpdb global in WP_Privacy_Requests_Table::prepare_items().

Props david.binda.
Fixes #48178.

Note: See TracTickets for help on using tickets.