WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 19 years ago

#4818 closed defect (bug) (fixed)

$newday global declaration is unnecessary, and $currentmonth not global'ed

Reported by: JeremyVisser Owned by:
Priority: low Milestone: 2.3
Component: Template Version: 2.3
Severity: normal Keywords:
Cc: Focuses:

Description


Attachments (2)

general-template.php.diff​ (468 bytes ) - added by JeremyVisser 19 years ago.
Removes excess global declaration.
4818.2.diff​ (995 bytes ) - added by JeremyVisser 19 years ago.
Fixes both problems described.

Download all attachments as: .zip

Change History (7)

#1 @JeremyVisser
19 years ago

Sorry, blank ticket.

In wp-includes/general-template.php, there is a global declaration of $newday in function the_date(), but it is never used. Attaching a patch to get rid of it.

@JeremyVisser
19 years ago

Removes excess global declaration.

#2 @JeremyVisser
19 years ago

  • Severity trivial → normal
  • Summary $newday global declaration is unnecessary → $newday global declaration is unnecessary, and $currentmonth not global'ed

In addition, $currentmonth is set in setup_postdate() in wp-includes/query.php, but never global'ed.

(It was preventing me from creating a custom the_month() function like the_date(), making this ticket slightly more serious.)

@JeremyVisser
19 years ago

Fixes both problems described.

#3 @ryan
19 years ago

  • Resolution → fixed
  • Status new → closed

(In [5944]) Add missing global and remove unused var. Props JeremyVisser. fixes #4818

#4 @JeremyVisser
19 years ago

  • Milestone 2.3 → 2.2.3
  • Resolution fixed
  • Status closed → reopened
  • Version 2.3 → 2.2.2

Backport to 2.2.3?

#5 @DD32
19 years ago

  • Milestone 2.2.3 → 2.3
  • Resolution → fixed
  • Status reopened → closed
  • Version 2.2.2 → 2.3

2.2.x is not maintained anymore, changing back to fixed.

Note: See TracTickets for help on using tickets.