Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#48185 closed enhancement (fixed)

Remove old todo: Don't hard code activation link.

Reported by: david.binda Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: trivial Version: 3.0
Component: Networks and Sites Keywords:
Focuses: docs, multisite Cc:


I've stumbled upon this TODO line in wp-includes/ms-functins.php file:

// TODO: Don't hard code activation link.

It originates in r 543 of the mu repository. By that time, the activation link was really hardcoded:

$message = sprintf(__("To activate your blog, please click the following link:\n\n%s\n\nAfter you activate, you will receive *another email* with your login.\n\nAfter you activate, you can visit your blog here:\n\n%s\n\nAnd you can login on the home page:\n\nhttp://wordpress.com/"), 
    "http://wordpress.com/activate/$key", "http://$domain");
    // TODO: Don't hard code activation link.

The current message is being composed using the $activate_url, which has been introduced in r 550 of the mu repository, I believe that the TODO comment is no longer needed.

Attachments (1)

48185.diff (430 bytes) - added by david.binda 9 months ago.

Download all attachments as: .zip

Change History (4)

9 months ago

#1 @david.binda
9 months ago

  • Version set to 3.0

#2 @SergeyBiryukov
9 months ago

  • Component changed from General to Networks and Sites
  • Focuses docs multisite added
  • Milestone changed from Awaiting Review to 5.3

As far as I can see, $activate_url was introduced in mu:585.

The hardcoding, however, was addressed earlier in mu:547, so the comment is indeed no longer relevant.

#3 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46367:

Docs: Remove obsolete comment in wpmu_signup_blog_notification() and wpmu_signup_user_notification().

Props david.binda.
Fixes #48185.

Note: See TracTickets for help on using tickets.