Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48188 closed defect (bug) (fixed)

Parent Category shouldn't extend past other fields in Add New Category

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-screenshots commit
Focuses: ui Cc:

Description

While testing long titles I found the Parent Category in the Add New Category form extends beyond the other fields causing it to appear mis-aligned.

Attachments (5)

48188.diff (312 bytes) - added by garrett-eclipse 5 years ago.
Set max-width on the #parent select in Add New Category to 95% to match the other inputs
Screen Shot 2019-10-01 at 12.03.19 AM.png (165.0 KB) - added by garrett-eclipse 5 years ago.
BEFORE: Long title causes the select to extend beyond the other inputs
Screen Shot 2019-10-01 at 12.05.19 AM.png (165.8 KB) - added by garrett-eclipse 5 years ago.
Set the max-width to 95% to match the other inputs
Screenshot 2019-10-01 13.17.01.png (122.6 KB) - added by dkarfa 5 years ago.
48188.1.patch (387 bytes) - added by dkarfa 5 years ago.

Download all attachments as: .zip

Change History (10)

@garrett-eclipse
5 years ago

Set max-width on the #parent select in Add New Category to 95% to match the other inputs

@garrett-eclipse
5 years ago

BEFORE: Long title causes the select to extend beyond the other inputs

@garrett-eclipse
5 years ago

Set the max-width to 95% to match the other inputs

#1 @garrett-eclipse
5 years ago

  • Summary changed from Parent Category shouldn't extend paste other fields in Add New Category to Parent Category shouldn't extend past other fields in Add New Category

@dkarfa
5 years ago

#2 @dkarfa
5 years ago

<p> Tags content going outside and it will fix their width as well as.

#3 @garrett-eclipse
5 years ago

  • Keywords has-patch has-screenshots needs-testing added
  • Milestone changed from Awaiting Review to 5.3

Thanks @dkarfa good catch. Aside from another tester/review this is looking good and since it's a bug may be able to still make it into 5.3.

#4 @davidbaumwald
5 years ago

  • Keywords commit added; needs-testing removed

Tested the most recent patch, and it works great. This is a good match with 5.3's scope, so I'm marking this for commit.

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46405:

Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.

Props garrett-eclipse, dkarfa.
Fixes #48188.

Note: See TracTickets for help on using tickets.