WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 77 minutes ago

#48189 accepted defect (bug)

Fix mobile display of Privacy Request email input & button

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch commit
Focuses: ui, css, administration Cc:
PR Number:

Description

Currently, the privacy request email inputs don't follow the convention of the search on list tables. This causes a mobile display inconsistency and can end up having the buttons smushed up against the input.

Attachments (6)

48189.diff (474 bytes) - added by garrett-eclipse 4 months ago.
Mobile CSS to have the privacy request inputs coincide with the search input styling
Screen Shot 2019-10-01 at 12.23.33 AM.png (134.7 KB) - added by garrett-eclipse 4 months ago.
Before: Small tablet
Screen Shot 2019-10-01 at 12.23.25 AM.png (133.3 KB) - added by garrett-eclipse 4 months ago.
Before: mobile w/ button/input on request form smushed up together
Screen Shot 2019-10-01 at 12.29.12 AM.png (134.4 KB) - added by garrett-eclipse 4 months ago.
After: Adding the mobile css has the input coincide nicely with the search input and properly spaces it from the action button
Screen Shot 2019-12-16 at 7.24.55 PM.png (60.8 KB) - added by garrett-eclipse 5 weeks ago.
Before
Screen Shot 2019-12-16 at 7.27.13 PM.png (60.5 KB) - added by garrett-eclipse 5 weeks ago.
After

Download all attachments as: .zip

Change History (10)

@garrett-eclipse
4 months ago

Mobile CSS to have the privacy request inputs coincide with the search input styling

@garrett-eclipse
4 months ago

Before: mobile w/ button/input on request form smushed up together

@garrett-eclipse
4 months ago

After: Adding the mobile css has the input coincide nicely with the search input and properly spaces it from the action button

#1 @garrett-eclipse
5 weeks ago

  • Focuses css administration added
  • Keywords has-screenshots has-patch needs-testing needs-design-feedback added
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to garrett-eclipse
  • Status changed from new to accepted
  • Version set to 4.9.6

Retesting this on trunk (post-5.3) it still applies cleanly and resolves the issue.
*Although the ui has changed in 5.3 I haven't found any conflict (screenshots coming)

#2 @audrasjb
4 days ago

#49232 was marked as a duplicate.

#3 @xkon
3 hours ago

  • Keywords commit added; needs-testing removed

Looks ok to me @garrett-eclipse, thanks!

Marking this for commit, it's a simple fix and makes sense to have everything aligned & showing in the same manner :-).

#4 @garrett-eclipse
77 minutes ago

  • Keywords needs-design-feedback removed
Note: See TracTickets for help on using tickets.