WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48200, comment 5


Ignore:
Timestamp:
10/05/2019 03:47:26 PM (6 weeks ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48200, comment 5

    initial v1  
    22> I don't think this is strictly necessary, but for consideration, I uploaded a patch that only sends the header in the API endpoints instead of the lower level sub-sizing functions.
    33
    4 This will change the way (prevent) how this is used outside the API. With 48200.2.diff it won't be able to retry to make sub-sizes when using `wp_create_image_subsizes()` or wp_update_image_subsizes()` directly.
     4This will change the way (prevent) how this is used outside the API. With 48200.2.diff it won't be able to retry to make sub-sizes when using `wp_create_image_subsizes()` or `wp_update_image_subsizes()` directly.
    55
    66I'm actually thinking the opposite :) The API shouldn't be concerned about this header at all, It is part of "site health" fatal error protection. Also thinking it may make sense to always set it for all uploads, so plugins have a chance to "do something" or at least show better error messages when any upload fails.