WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#48212 closed defect (bug) (wontfix)

Remove deprecated function

Reported by: dkarfa's profile dkarfa Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

#41217 maybe_log_events_response() function deprecated.

Attachments (3)

48212.patch​ (955 bytes) - added by dkarfa 5 years ago.
48212.1.patch​ (2.8 KB) - added by dkarfa 5 years ago.
48212.2.patch​ (3.2 KB) - added by dkarfa 5 years ago.

Download all attachments as: .zip

Change History (8)

@dkarfa
5 years ago

@dkarfa
5 years ago

@dkarfa
5 years ago

#1 @swissspidy
5 years ago

  • Keywords close added

@dkarfa Could you explain these patches? 48212.1.patch​ and 48212.2.patch​ don't really work as you remove a class method and then create a new function.

We also cannot just outright remove the method as in 48212.patch​ as plugins might still be using it (hence the deprecation).

WordPress doesn't really have a strong deprecation policy (e.g. we don't typically remove deprecated functions after x releases), so my recommendation here is to just leave this as-is.

#2 @dkarfa
5 years ago

Hey @swissspidy
Thank, Got you! I think you are right.

Last edited 5 years ago by dkarfa (previous) (diff)

#3 @desrosj
5 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted

#4 @SergeyBiryukov
5 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

#5 @SergeyBiryukov
5 years ago

  • Component changed from General to Administration
Note: See TracTickets for help on using tickets.