WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#48212 closed defect (bug) (wontfix)

Remove deprecated function

Reported by: dkarfa Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:
PR Number:

Description

#41217 maybe_log_events_response() function deprecated.

Attachments (3)

48212.patch (955 bytes) - added by dkarfa 2 months ago.
48212.1.patch (2.8 KB) - added by dkarfa 2 months ago.
48212.2.patch (3.2 KB) - added by dkarfa 2 months ago.

Download all attachments as: .zip

Change History (8)

@dkarfa
2 months ago

@dkarfa
2 months ago

@dkarfa
2 months ago

#1 @swissspidy
2 months ago

  • Keywords close added

@dkarfa Could you explain these patches? 48212.1.patch and 48212.2.patch don't really work as you remove a class method and then create a new function.

We also cannot just outright remove the method as in 48212.patch as plugins might still be using it (hence the deprecation).

WordPress doesn't really have a strong deprecation policy (e.g. we don't typically remove deprecated functions after x releases), so my recommendation here is to just leave this as-is.

#2 @dkarfa
2 months ago

Hey @swissspidy
Thank, Got you! I think you are right.

Last edited 2 months ago by dkarfa (previous) (diff)

#3 @desrosj
2 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted

#4 @SergeyBiryukov
2 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

#5 @SergeyBiryukov
2 months ago

  • Component changed from General to Administration
Note: See TracTickets for help on using tickets.