WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#48214 closed defect (bug) (fixed)

Add missing `@param` for first parameter passed to `big_image_size_threshold`

Reported by: desrosj Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Media Keywords: needs-patch good-first-bug
Focuses: docs Cc:
PR Number:

Description

The big_image_size_threshold filter is passed 4 values, but only three are documented inline. The first one, threshold value, needs a @param tag with the appropriate parts.

Attachments (2)

48214.patch (1.3 KB) - added by dkarfa 2 months ago.
48214.1.patch (1.3 KB) - added by dkarfa 2 months ago.
Oops, fix typo error.

Download all attachments as: .zip

Change History (5)

#1 @desrosj
2 months ago

See #47873. Introduced in [46076].

@dkarfa
2 months ago

#2 @earnjam
2 months ago

@dkarfa Thank you for the patch.

In the future I would suggest to leave tickets marked good-first-bug for people who are new to contributing so they can learn the process of getting involved.

There is also a typo in your patch. It says patam instead of param

@dkarfa
2 months ago

Oops, fix typo error.

#3 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46398:

Docs: Add missing documentation for the first parameter of the big_image_size_threshold filter.

Props dkarfa, desrosj, earnjam.
Fixes #48214.

Note: See TracTickets for help on using tickets.