Changes between Initial Version and Version 1 of Ticket #48222, comment 41
- Timestamp:
- 02/18/2020 11:14:34 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48222, comment 41
initial v1 4 4 - as there's now visible text, there's no need to have an `aria-label`: it should be removed together with the JS part meant to update its value 5 5 - some CSS values seem a bit "magic numbers", for example `line-height: 2.15;` based on `font-size: 12px;` computes to `25.8` pixels: it would be nice to have some meaningful numbers instead (with no decimals) 6 - on button activation, the icon updates but the visible text doesn't and it's always "Show"