WordPress.org

Make WordPress Core

Opened 2 weeks ago

Last modified 2 weeks ago

#48244 new defect (bug)

script-loader.php Need to use _n() when more than one results are found

Reported by: tobifjellner Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.5
Component: Script Loader Keywords: good-first-bug needs-patch
Focuses: Cc:
PR Number:

Description

Location:
https://build.trac.wordpress.org/browser/trunk/wp-includes/script-loader.php?marks=1178#L1178

Content:

'manyResults'  => __( '%d results found. Use up and down arrow keys to navigate.' ),

should (if possible) be converted to use _n() in order for some languages to be able to correctly construct the phrase.

Change History (2)

#1 @swissspidy
2 weeks ago

The correct number is only known client-side, so for correct results one would need to use _n() from the @wordpress/i18n JS package.

This would need to happen in at least two places:

https://github.com/WordPress/wordpress-develop/blob/3b14a06c8cb187d8abd3d4af8ea9c0ea3a475228/src/js/_enqueues/vendor/tinymce/plugins/wplink/plugin.js#L459-L469
https://github.com/WordPress/wordpress-develop/blob/715a65c56142262b938d6860f840e201b1fe074a/src/js/_enqueues/admin/tags-suggest.js#L135-L144

However, this is by far not the only place where plural forms in JS could or should be improved. In #20491 you can find a huge patch with possible changes.

#2 @SergeyBiryukov
2 weeks ago

  • Version changed from trunk to 4.5

Introduced in [36806].

Note: See TracTickets for help on using tickets.