Consistent deprecation of PHP 4 constructors

[jrf]

While testing a new sniff for WPCS, I ran into an number of inconsistencies in the use of the ​`_deprecated_constructor()` function.

In particular:

• Missing @deprecated tags in the function docblock of some PHP4 constructors.
• Some PHP4 constructors in (external) dependencies not being marked as deprecated.

The attached patches would fix these inconsistencies.

Previous ticket: #31982

Related: #41121

[jrf]

WP_Widget(_Factory): PHP4 constructor / missing @deprecated tags

[jrf]

Twenty Eleven: mark PHP-4 constructor as deprecated As per [33086], no call to _deprecated_constructor() is added as the theme can be used by WordPress versions from before the function was introduced.

[jrf]

Pomo: Deprecate PHP-4 style constructors

[andraganescu]

Just noting that all these patches apply cleanly.

[SergeyBiryukov]

In 46627:

Docs: Add missing @deprecated tags to PHP 4 constructors in WP_Widget and WP_Widget_Factory().

Correct version number in _deprecated_constructor() call in WP_Widget_Factory(), see [32990].

Props jrf.
See #48252.

[SergeyBiryukov]

In 46628:

Twenty Eleven: Add missing @deprecated tag to PHP 4 constructor in Twenty_Eleven_Ephemera_Widget.

Props jrf.
See #48252.

[SergeyBiryukov]

In 46629:

Docs: Add missing @deprecated tags to PHP 4 constructors in pomo/entry.php and pomo/streams.php.

Props jrf.
Fixes #48252.

[SergeyBiryukov]

In 46630:

Docs: Correct @see references for PHP 4 constructors in wp-includes/class-json.php.

See #48252, #48303.

[jrf]

Thanks @SergeyBiryukov for getting these committed!

I just noticed that in [46629], the version numbers still refer to 5.3.0 (when I created the patches), while trunk is currently 5.4.0. Should that still be fixed ?

[SergeyBiryukov]

Replying to jrf:

I just noticed that in [46629], the version numbers still refer to 5.3.0 (when I created the patches), while trunk is currently 5.4.0. Should that still be fixed ?

Ah, good catch, missed that :) Thanks!

[SergeyBiryukov]

In 46631:

Docs: Correct version number in @deprecated tags for PHP 4 constructors in pomo/entry.php and pomo/streams.php.

Follow-up to [46629].

Props jrf.
See #48252.

[SergeyBiryukov]

In 46632:

Code Modernization: Call PHP 5 constructors in methods extending POMO_Reader.

Follow-up to [46629].

See #48252.