WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 6 weeks ago

#48267 new defect (bug)

IXR: Modernize IXR library

Reported by: kraftbj Owned by:
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords:
Focuses: Cc:
PR Number:

Description

Motivated by #47678, I started updating func_get_args calls in a plugin that extended the IXR classes provided by Core and realized that I was getting ahead of myself and Core.

With this coming from a seemingly abandoned upstream library where we haven't modernize the code in some time, before doing more (PHPCS, inline docs, etc), what is the status of this part of the code? Open to being modernized?

Attaching a simple patch for the spread operator to start the discussion.

Subtasks:

  • Remove PHP 4 and pre-PHP 5.6 conventions.
  • PHPCS.
  • Inline documentation.

Related: #46484

Attachments (1)

48267.diff (1.4 KB) - added by kraftbj 2 months ago.
Add spread operator

Download all attachments as: .zip

Change History (3)

@kraftbj
2 months ago

Add spread operator

#1 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.4

#2 in reply to: ↑ description @SergeyBiryukov
6 weeks ago

Replying to kraftbj:

With this coming from a seemingly abandoned upstream library where we haven't modernize the code in some time, before doing more (PHPCS, inline docs, etc), what is the status of this part of the code? Open to being modernized?

Looking at the recent commits, of which [38389] is probably the most substantial:

it appears to be treated as "adopted" rather than external, so I think we should bring it in line with the rest of core.

Note: See TracTickets for help on using tickets.