IXR: Use spread args (was Modernize IXR library)

[kraftbj]

Motivated by #47678, I started updating func_get_args calls in a plugin that extended the IXR classes provided by Core and realized that I was getting ahead of myself and Core.

With this coming from a seemingly abandoned upstream library where we haven't modernize the code in some time, before doing more (PHPCS, inline docs, etc), what is the status of this part of the code? Open to being modernized?

Attaching a simple patch for the spread operator to start the discussion.

Subtasks:

• Remove PHP 4 and pre-PHP 5.6 conventions.
• PHPCS.
• Inline documentation.

Related: #46484

[kraftbj]

Add spread operator

[SergeyBiryukov]

Replying to kraftbj:

With this coming from a seemingly abandoned upstream library where we haven't modernize the code in some time, before doing more (PHPCS, inline docs, etc), what is the status of this part of the code? Open to being modernized?

Looking at the recent commits, of which [38389] is probably the most substantial:

• https://core.trac.wordpress.org/log/trunk/src/wp-includes/IXR
• https://core.trac.wordpress.org/log/trunk/src/wp-includes/class-IXR.php

it appears to be treated as "adopted" rather than external, so I think we should bring it in line with the rest of core.

[audrasjb]

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[SergeyBiryukov]

In 48204:

Code Modernization: Introduce the spread operator in wp-includes/IXR.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props kraftbj.
See #48267, #47678.

[SergeyBiryukov]

[48204] should be mentioned in a dev note.

Keeping the ticket open for now to address the other subtasks from the description.

[ayeshrajans]

Please note that this breaks PHP 8 builds because PHP 8 enforce strict LSP checks: ​https://php.watch/versions/8.0/lsp-errors

Build: ​https://travis-ci.com/github/Ayesh/wordpress-develop/jobs/355902441#L2647

In versions prior to PHP 8, this change still raises a warning, so I think this needs to be fixed before 5.5 even though we target 5.6 for PHP 8.

[SergeyBiryukov]

In 48238:

Code Modernization: Introduce the spread operator in WP_HTTP_IXR_Client.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This makes the signature of WP_HTTP_IXR_Client::query() compatible with the parent class method.

Follow-up to [48204].

Props ayeshrajans.
See #48267, #47678.

[ayeshrajans]

Thanks a lot for quickly picking this up @SergeyBiryukov 🙏🏿.

[desrosj]

I am in the process of drafting the dev note and just confirmed this is in the list of notes being tracked by the release squad. Going to close this out to help clear the milestone in advance of beta 1 tomorrow.

[kraftbj]

Thanks @desrosj. I'll open up a new ticket to track more specific pieces of this to save the need to juggle tickets moving forward.

[desrosj]

Referenced in the following dev note: ​https://make.wordpress.org/core/2020/07/14/php-related-improvements-changes-wordpress-5-5-edition/.