![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 years ago
Closed 7 years ago
#48271 closed defect (bug) (fixed)
Media Library: Tab structure does not use tab semantics
| Reported by: | mayanksonawat | Owned by: | afercia |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.3.1 |
| Component: | Media | Version: | |
| Severity: | normal | Keywords: | has-screenshots has-patch aria-current fixed-major |
| Cc: | Focuses: | ui, accessibility, administration |
Description
In admin side media section when you switch the grid view to list view then you will found the same issue as ticket #47149
These are coded as links with redundant href attributes ("#"),
which is not semantically valid, and does not convey the
currently-active link to assistive technologies.
Attachments (2)
Change History (14)
#1
@
7 years ago
- Component General → Media
- Focuses ui accessibility added
- Summary The issue is related ti ticket #47149. → Media Library: Tab structure does not use tab semantics
#3
in reply to: ↑ 2
@
7 years ago
@afercia thanks for your prompt reply. I're saying about tabbing for media, please ignore for href="#", Reloading of page for Tabing may not be a good practise.
#4
follow-up:
↓ 6
@
7 years ago
- Keywords needs-patch has-screenshots added; reporter-feedback removed
Thanks @mayanksonawat. Thinking the list and grid mode links should have an aria-current attribute. As you pointed out, there's no semantic indication of the currently active link.
#5
@
7 years ago
- Keywords has-patch added; needs-patch removed
- Milestone Awaiting Review → 5.3.1
48271.diff adds aria-current="page" to the "switch view" links in the list tables. It's a small, self-contained, improvements that continues the introduction in core of aria-current. As such, I'd like to propose this for 5.3.1 consideration.
#6
in reply to: ↑ 4
@
7 years ago
- Keywords needs-patch added; has-patch removed
- Resolution → maybelater
- Status new → closed
Replying to afercia:
Thanks @mayanksonawat. Thinking the list and grid mode links should have an
aria-currentattribute. As you pointed out, there's no semantic indication of the currently active link.
#7
@
7 years ago
- Keywords has-patch added; needs-patch removed
- Resolution maybelater
- Status closed → reopened
Let's keep this ticket open to add the aria-current attribute :)
#10
@
7 years ago
- Keywords fixed-major added
- Resolution fixed
- Status closed → reopened
This change is simple and self-contained enough, I'd like to propose it for 5.3.1 consideration.
@mayanksonawat thanks for your report. I'm not sure I fully understand. What are the links with a
href="#"in this page?