WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 2 days ago

#48271 reopened defect (bug)

Media Library: Tab structure does not use tab semantics

Reported by: mayanksonawat Owned by: afercia
Milestone: 5.3.1 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch aria-current fixed-major
Focuses: ui, accessibility, administration Cc:
PR Number:

Description

In admin side media section when you switch the grid view to list view then you will found the same issue as ticket #47149
These are coded as links with redundant href attributes ("#"),
which is not semantically valid, and does not convey the
currently-active link to assistive technologies.

Attachments (2)

Screenshot from 2019-10-10 15-22-24.png (187.3 KB) - added by mayanksonawat 6 weeks ago.
48271.diff (1.7 KB) - added by afercia 4 weeks ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
6 weeks ago

  • Component changed from General to Media
  • Focuses ui accessibility added
  • Summary changed from The issue is related ti ticket #47149. to Media Library: Tab structure does not use tab semantics

#2 follow-up: @afercia
5 weeks ago

  • Keywords reporter-feedback added

@mayanksonawat thanks for your report. I'm not sure I fully understand. What are the links with a href="#" in this page?

#3 in reply to: ↑ 2 @mayanksonawat
4 weeks ago

@afercia thanks for your prompt reply. I're saying about tabbing for media, please ignore for href="#", Reloading of page for Tabing may not be a good practise.

Last edited 4 weeks ago by mayanksonawat (previous) (diff)

#4 follow-up: @afercia
4 weeks ago

  • Keywords needs-patch has-screenshots added; reporter-feedback removed

Thanks @mayanksonawat. Thinking the list and grid mode links should have an aria-current attribute. As you pointed out, there's no semantic indication of the currently active link.

http://cldup.com/99LK0xeuML.png

@afercia
4 weeks ago

#5 @afercia
4 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.3.1

48271.diff adds aria-current="page" to the "switch view" links in the list tables. It's a small, self-contained, improvements that continues the introduction in core of aria-current. As such, I'd like to propose this for 5.3.1 consideration.

#6 in reply to: ↑ 4 @mayanksonawat
4 weeks ago

  • Keywords needs-patch added; has-patch removed
  • Resolution set to maybelater
  • Status changed from new to closed

Replying to afercia:

Thanks @mayanksonawat. Thinking the list and grid mode links should have an aria-current attribute. As you pointed out, there's no semantic indication of the currently active link.

http://cldup.com/99LK0xeuML.png

#7 @afercia
4 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Resolution maybelater deleted
  • Status changed from closed to reopened

Let's keep this ticket open to add the aria-current attribute :)

#8 @afercia
2 days ago

  • Keywords aria-current added

#9 @afercia
2 days ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from reopened to closed

In 46746:

Accessibility: Add an aria-current attribute to the Media Library switch links.

The aria-current attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.

#10 @afercia
2 days ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

This change is simple and self-contained enough, I'd like to propose it for 5.3.1 consideration.

Note: See TracTickets for help on using tickets.