WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#48276 closed defect (bug) (reported-upstream)

Hide the snackbar action components link on focus

Reported by: Mahesh901122 Owned by:
Priority: normal Milestone:
Component: Editor Version: 5.3
Severity: normal Keywords: 2nd-opinion
Cc: Focuses: ui

Description

Default message:

https://maheshwaghmare.files.wordpress.com/2019/10/image-2019-10-10-at-7.11.13-pm.png

Default message + focus:
https://maheshwaghmare.files.wordpress.com/2019/10/image-2019-10-10-at-7.12.37-pm.png

I think the possible fix for this issue is update the below selector:

.components-snackbar__action.components-button:not(:disabled):not([aria-disabled="true"]):not(.is-default)

with:

.components-snackbar__action.components-button:not(:disabled):not([aria-disabled="true"]):not(.is-default):not(:focus)

from files:

wp-includes/css/dist/components/style.css
wp-includes/css/dist/components/style-rtl.css

Attachments (2)

Image 2019-10-10 at 7.11.13 PM.png​ (1.9 KB ) - added by Mahesh901122 7 years ago.
Default Message
Image 2019-10-10 at 7.12.37 PM.png​ (77.7 KB ) - added by Mahesh901122 7 years ago.
Default Message + Focus

Download all attachments as: .zip

Change History (6)

@Mahesh901122
7 years ago

Default Message

@Mahesh901122
7 years ago

Default Message + Focus

#1 @swissspidy
7 years ago

A pull request for ​https://github.com/WordPress/gutenberg/blob/master/packages/components/src/snackbar/style.scss would be needed for such a change. Would you mind submitting one? :-)

#2 @Mahesh901122
7 years ago

I have added the PR on GitHub. PR URL is ​https://github.com/WordPress/gutenberg/pull/17887

So, Can you please close this ticket? Or I need to close it?

Version 0, edited 7 years ago by Mahesh901122 (next)

#3 @SergeyBiryukov
7 years ago

  • Milestone Awaiting Review
  • Resolution → reported-upstream
  • Status new → closed

Thanks for the follow-up!

#4 @gziolo
7 years ago

It was replicated in Gutenberg, patch coming up soon there, thanks!

Note: See TracTickets for help on using tickets.