WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 9 months ago

#48286 closed defect (bug) (fixed)

Avoid use of mdash in starter content for day separator Monday—Friday

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: good-first-bug has-patch has-screenshots commit
Focuses: Cc:

Description

In the starter content there's a mix of mdash and ndash when it should only be ndash as the separator in dates and times.
https://github.com/WordPress/wordpress-develop/blob/7a682e690e4915411777080ebc2999da69ad3a39/src/wp-includes/theme.php#L2058

The ndash standardly is the "through" indicator for showing inclusive dates and numbers.
While the mdash is an interruptor and used as an aside.

As such the content - Monday—Friday: 9:00AM–5:00PM
Should simply be - Monday–Friday: 9:00AM–5:00PM

Originally opened here;
https://github.com/WordPress/twentytwenty/issues/830

Attachments (2)

48286.diff (892 bytes) - added by mikejdent 12 months ago.
Screen Shot 2020-01-29 at 11.41.35 PM.png (27.0 KB) - added by garrett-eclipse 9 months ago.
Test result

Download all attachments as: .zip

Change History (6)

#1 @SergeyBiryukov
13 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Summary changed from Avoid use of mdash in starter content for day seperator Monday—Friday to Avoid use of mdash in starter content for day separator Monday—Friday

@mikejdent
12 months ago

#2 @mikejdent
12 months ago

  • Keywords has-patch added

Updated to use ndash instead of mdash

#3 @garrett-eclipse
9 months ago

  • Keywords has-screenshots commit added
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

Thanks for the contribution @mikejdent your patch applies and works nicely, appreciated.

Marking for commit, into your hands @SergeyBiryukov

#4 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47134:

Themes: Replace — with – as a separator between Monday and Friday in theme starter content.

The ndash standardly is the "through" indicator for showing inclusive dates and numbers, while the mdash is an interruptor and used as an aside.

Props mikejdent, garrett-eclipse.
Fixes #48286.

Note: See TracTickets for help on using tickets.