WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#48296 closed defect (bug) (fixed)

Fixed typo in `WP_REST_Settings_Controller::prepare_value`

Reported by: itowhid06 Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: REST API Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

Fixed a typo in WP_REST_Settings_Controller::prepare_value.

Attachments (1)

48296.diff (872 bytes) - added by itowhid06 4 months ago.

Download all attachments as: .zip

Change History (7)

@itowhid06
4 months ago

#1 @desrosj
4 months ago

  • Milestone changed from Awaiting Review to 5.3

Hi @itowhid06 ,

Thanks for this ticket, and the others you’ve been making. The effort is greatly appreciated!

Moving forward, can you please not open a different ticket for each individual typo? Instead, there is a general documentation ticket for each release. For 5.3, you can see #47110.

The ones you have made can remain, but it makes it much more difficult to have 30 tickets for small typos than one to fix all of them at the same time.

#2 @itowhid06
4 months ago

@desrosj, Thanks for the heads up :)

#3 follow-up: @peterwilsoncc
4 months ago

I've sort some clarification on the comment in general, as this is a documentation fix it can remain on the milestone after the RC as it doesn't affect the executed code.

#4 in reply to: ↑ 3 @SergeyBiryukov
4 months ago

Replying to peterwilsoncc:

I've sort some clarification on the comment in general, as this is a documentation fix it can remain on the milestone after the RC as it doesn't affect the executed code.

That's technically correct, but I think we'd like to clear the milestone before RC :)

#5 @SergeyBiryukov
4 months ago

In 46471:

Docs: Fix typo in a comment in WP_REST_Settings_Controller::prepare_value().

Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.

#6 @peterwilsoncc
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

@SergeyBiryukov Yeah, that's why I went for DMs rather than mentions here.

I thought there might be a typo changing the intended meaning of the comment but there isn't. While the comment could do with clarification, that can happen on the general docs ticket rather than here.

Note: See TracTickets for help on using tickets.