WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#48297 closed defect (bug) (fixed)

Added missing property in `WP_REST_Autosaves_Controller` class

Reported by: itowhid06's profile itowhid06 Owned by: timothyblynjacobs's profile TimothyBlynJacobs
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.0
Component: REST API Keywords: has-patch
Focuses: docs Cc:

Description

Added missing property $rest_namespace in WP_REST_Autosaves_Controller class

Attachments (2)

48297.diff​ (648 bytes) - added by itowhid06 6 years ago.
48297.1.diff​ (1.4 KB) - added by itowhid06 6 years ago.
Using $this->namespace instead of $this->rest_namespace

Download all attachments as: .zip

Change History (7)

@itowhid06
6 years ago

#1 @desrosj
6 years ago

  • Focuses docs added
  • Milestone changed from Awaiting Review to Future Release

#2 @TimothyBlynJacobs
6 years ago

  • Keywords needs-patch added; has-patch removed

The autosaves controller should be using $this->namespace which is defined by WP_REST_Controller as protected instead of its own property here.

@itowhid06
6 years ago

Using $this->namespace instead of $this->rest_namespace

#3 @itowhid06
6 years ago

  • Keywords has-patch added; needs-patch removed

Updated the patch according to suggestion of @TimothyBlynJacobs .

#4 @TimothyBlynJacobs
5 years ago

  • Milestone changed from Future Release to 5.6
  • Version set to 5.0

Thanks for the refresh @itowhid06!

#5 @TimothyBlynJacobs
5 years ago

  • Owner set to TimothyBlynJacobs
  • Resolution set to fixed
  • Status changed from new to closed

In 49300:

REST API: Reuse namespace property instead of the undeclared rest_namespace.

Props itowhid06.
Fixes #48297.

Note: See TracTickets for help on using tickets.