WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#4830 closed defect (bug) (fixed)

Not all references to wp-admin.css get cache busted

Reported by: mdawaffe Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Most everywhere, wp-admin.css is cache busted by appending a version parameter to the query string.

But not everywhere.

Additionally, we don't include rtl stylesheets in all places.

Attached:

  1. wp_admin_css_uri( $file = 'wp-admin' ) returns the absolute URL of the requested admin css file. $file is the name of the file (with path relative to /wp-admin) and without the .css extension.
  2. wp_admin_css( $file = 'wp-admin' ) echoes <link rel="stylesheet" /> markup for the requested admin css file and it's rtl equivalent if necessary.

Complete with filters.

Or we could just go through and make sure every css file is cache busted appropriately.

Attachments (1)

4830.diff (9.6 KB) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (3)

mdawaffe7 years ago

comment:1 ryan7 years ago

  • Milestone changed from 2.4 (next) to 2.3

comment:2 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5965]) Make css cache busting and rtl inclusion uniform across admin. Props mdawaffe. fixes #4830

Note: See TracTickets for help on using tickets.