WordPress.org

Make WordPress Core

Opened 9 months ago

Last modified 3 weeks ago

#48301 new enhancement

Backport the simplified local environment

Reported by: desrosj Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-testing has-patch
Focuses: Cc:

Description

This is a continuation ticket of #47767.

In that ticket, a Docker-based local WordPress Development environment was added to trunk.

This ticket is being opened to accomplish the 3rd goal listed on the ticket, It should be simple to backport to old branches, so we can more easily set up test environments when backporting patches to old branches.

https://core.trac.wordpress.org/ticket/47767#comment:6 has an initial proof of concept for backporting the environment to 3.7, though it needs to be updated to account for the changes made further down in the ticket.

Change History (12)

This ticket was mentioned in PR #125 on WordPress/wordpress-develop by desrosj.


7 months ago

This ticket was mentioned in PR #133 on WordPress/wordpress-develop by desrosj.


6 months ago

This ticket was mentioned in PR #134 on WordPress/wordpress-develop by desrosj.


6 months ago

This ticket was mentioned in PR #135 on WordPress/wordpress-develop by desrosj.


6 months ago

This ticket was mentioned in PR #136 on WordPress/wordpress-develop by desrosj.


6 months ago

This ticket was mentioned in PR #137 on WordPress/wordpress-develop by desrosj.


6 months ago

#7 @desrosj
6 months ago

  • Keywords has-patch added; needs-patch removed

I finally got some working branches pushed to my GitHub fork. You can find the PRs linked above.

I started by only going back to 4.8. At this point, I stop encountering new problems. Solving these first will most likely make going back further go much more smoothly.

For each .env file, I have changed LOCAL_PHP-latest to load the highest version of PHP supported by that branch as the default to prevent any potential issues as newer latest builds are released. The LOCAL_MYSQL versions in the .env files need to be updated in the same fashion. I have been less involved in the MySQL version support changes, so I need to research when support for each new MySQL version was added.

I think making a MySQL version support page like the one for PHP versions would be very useful.

Some Notes

  • I kept build matrices exactly the same as they are now in each branch for this ticket. Trimming or expanding the build matrices can be explored in separate tickets after this transition is made.
  • To install the new required NPM packages (dotenv, dotenv-expand, and wait-on) and update the npm-shrinkwrap.json file correctly, I ran `npm install --save-dev --save-exact packagename@1.0.0.
  • Updating the npm-shrinkwarp-json file will cause fsevents to be re-added. This needs to be manually removed to avoid compatibility issues with non MacOS servers (including Travis, Docker, and the build server). See #38657.
  • npm ci does not appear to work on branches < 5.0. I switched the command to npm install.

Issues:

A few of the pull request Travis jobs are failing due to a time out when running npm ci. I'm not sure why as these jobs pass on my fork.

5.1 Branch

PHP 7.3, 7.2, 7.1: For some reason, the Tests_Image_Editor_Imagick::test_rotate and Tests_Image_Editor_Imagick::test_flip tests are reading the RGB values of the manipulated images incorrectly, getting an off by one value. This issue does not occur locally for me when running the test suite within the Docker container with the same versions configured.

PHP 5.4, 5.3, 5.2: The following error is being returned for these jobs:

/usr/local/bin/docker-php-ext-enable: 5: cd: can't cd to /usr/local/lib/php/extensions/no-debug-non-zts-20060613

5.0 Branch

PHP 7.3=: There is a Fatal error: Class PHPUnit_Util_Test may not inherit from final class (PHPUnit\Util\Test) in /var/www/tests/phpunit/includes/phpunit6-compat.php on line 18 happening. I believe that this is being caused because PHPUnit 7 is packaged in the PHP 7.1-7.3-fpm PHPUnit Docker images, but WordPress 5.0 only supported up to PHPUnit 6.

PHP 5.2: The same error is being encountered as PHP 5.4-5.2 above.

4.9 Branch

The wait-on >= 3.0.0 NPM package does not support NPM 6.9.1, which is the version used in this branch. Downgrading the package to 2.1.2 seems to work, but there is a potentially unrelated JavaScript error:

/home/travis/build/desrosj/wordpress-develop/tools/local-env/scripts/install.js:33 .then( () => { TypeError: Cannot read property 'then' of undefined at Object

This could also just be a compatibility issue with the install.js script and NPM 6.9.1.

For PHP 5.2, The same error is being caused above.

4.8 Branch

The same issues described for 4.9 also occur in this branch.

#8 @desrosj
6 months ago

Experimented with changing npm ci to npm install in the 5.2 branch. It fixed the timeout issue with the PHP 7.3 job, but introduced a new error for the 5.6 job: cb() never called!.

Also, here is a link to the Docker image for PHPUnit on PHP 7.1 loading PHPUnit 7: https://hub.docker.com/layers/wordpressdevelop/phpunit/7.1-fpm/images/sha256-7c8bccf4a538f8918c9223904cf1d59ff9811eba2836ef83391986659eb7afd5

Moving forward as support for newer versions of PHPUnit is added, there will likely be a need for more granularity here. @pento any thoughts on how to handle this?

#9 @prbot
4 months ago

noisysocks commented on PR #133:

Test test test

#10 @prbot
4 months ago

desrosj commented on PR #133:

Test

#11 @desrosj
2 months ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #core-committers by desrosj. View the logs.


3 weeks ago

Note: See TracTickets for help on using tickets.