Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48304, comment 11


Ignore:
Timestamp:
10/21/2019 07:28:52 PM (2 years ago)
Author:
chrisvanpatten
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48304, comment 11

    initial v1  
    11For whatever it's worth, I want to note that to me the simpler format here is a major advantage of this approach as it allows us to construct the URL to the "threshold" version from ''any'' size, without knowing exact dimensions. We were previously filtering core in gross/scary ways to get this behavior, and it's been amazing to be able to revert this code and use a simpler approach in core.
    22
    3 Frankly, I'd like to see this change rolled out across the board; using the image size name as the suffix instead of exact dimensions.
     3Frankly, I'd like to see this change rolled out across the board; using the image size name as the suffix instead of exact dimensions. I'd be very disappointed to see this go away.
    44
    5 I'd be very disappointed to see this go away.
     5Alternately, it would be nice to see this be filterable; as noted above we were doing very gross/scary hacks to be able to customize the saved file name. If there were a filter in place to be able to easily filter the generated file name, that would more-than alleviate my concerns.