WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#48309 closed task (blessed) (fixed)

Vary: Origin header needs to allow for header preservation.

Reported by: whyisjake's profile whyisjake Owned by: whyisjake's profile whyisjake
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: REST API Keywords: has-patch
Focuses: Cc:

Description

To fix, we simply need to add false as the second parameter.

This is something that we added downstream in the backports of 5.2, but we missed in 5.2/trunk. Patches included.

Attachments (2)

48309.diff​ (669 bytes) - added by whyisjake 5 years ago.
48309-5.2.diff​ (500 bytes) - added by whyisjake 5 years ago.

Download all attachments as: .zip

Change History (6)

@whyisjake
5 years ago

@whyisjake
5 years ago

#1 @whyisjake
5 years ago

  • Component changed from General to REST API
  • Owner set to whyisjake
  • Status changed from new to accepted

#2 @whyisjake
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46544:

REST API: Allow for multiple Vary: Origin headers in GET responses.

Simple fix, we pass false as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.

#3 @whyisjake
5 years ago

In 46545:

REST API: Allow for multiple Vary: Origin headers in GET responses.

Simple fix, we pass false as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309, see also [46544].
Props xknown, whyisjake.

#4 @whyisjake
5 years ago

  • Milestone changed from 5.2.5 to 5.3
Note: See TracTickets for help on using tickets.