WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#48309 closed task (blessed) (fixed)

Vary: Origin header needs to allow for header preservation.

Reported by: whyisjake Owned by: whyisjake
Priority: normal Milestone: 5.3
Component: REST API Version: 5.3
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

To fix, we simply need to add false as the second parameter.

This is something that we added downstream in the backports of 5.2, but we missed in 5.2/trunk. Patches included.

Attachments (2)

48309.diff​ (669 bytes ) - added by whyisjake 7 years ago.
48309-5.2.diff​ (500 bytes ) - added by whyisjake 7 years ago.

Download all attachments as: .zip

Change History (6)

@whyisjake
7 years ago

@whyisjake
7 years ago

#1 @whyisjake
7 years ago

  • Component General → REST API
  • Owner set to whyisjake
  • Status new → accepted

#2 @whyisjake
7 years ago

  • Resolution → fixed
  • Status accepted → closed

In 46544:

REST API: Allow for multiple Vary: Origin headers in GET responses.

Simple fix, we pass false as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.

#3 @whyisjake
7 years ago

In 46545:

REST API: Allow for multiple Vary: Origin headers in GET responses.

Simple fix, we pass false as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309, see also [46544].
Props xknown, whyisjake.

#4 @whyisjake
7 years ago

  • Milestone 5.2.5 → 5.3
Note: See TracTickets for help on using tickets.