WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 2 months ago

#48323 closed defect (bug) (fixed)

Signup link redirect is not filtered on multisite when a blog is not found

Reported by: calin's profile calin Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description

The signup link redirect is not filtered for multisite when a blog is not found. Usually, the links are generated using network_site_url( 'wp-signup.php' ) which applies the network_site_url filter but not when a redirect occurs because the blog is not found.

The relevant piece of code is here: ​https://github.com/WordPress/WordPress/blob/5.2.3/wp-includes/ms-load.php#L396-L435

I know that this code loads before plugins, but it is loaded after sunrise.php, so the filter cand be added in that file.

I've attach a patch for this.

Attachments (1)

network_site_url.diff​ (783 bytes) - added by calin 7 years ago.

Download all attachments as: .zip

Change History (12)

@calin
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Component changed from General to Networks and Sites

This ticket was mentioned in ​Slack in #core-multisite by realloc. ​View the logs.
12 months ago

This ticket was mentioned in ​Slack in #core-multisite by realloc. ​View the logs.
12 months ago

This ticket was mentioned in ​PR #8916 on ​WordPress/wordpress-develop by ​@realloc.
12 months ago #4

This is the patch for the ticket: https://core.trac.wordpress.org/ticket/48323

#5 @realloc
11 months ago

  • Owner set to realloc
  • Status changed from new to assigned

#6 @realloc
11 months ago

  • Owner changed from realloc to JJJ
  • Status changed from assigned to reviewing

#7 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 7.0

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
2 months ago

#9 @audrasjb
2 months ago

As per today's 7.0 bug scrub:
@johnjamesjacoby the PR looks good to go at a glance. As ticket owner, are you ok/able to ship it before the next beta?

#10 @audrasjb
2 months ago

  • Keywords commit added
  • Owner changed from JJJ to audrasjb
  • Status changed from reviewing to accepted

Self assigning for commit.

#11 @audrasjb
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62044:

Networks and Sites: Allow filtering signup link redirect when a blog is not found.

This changeset applies the existing network_site_url filter to the signup link redirect used when the blog is not found.

Props calin, realloc, audrasjb, peterwilsoncc.
Fixes #48323.

Note: See TracTickets for help on using tickets.