Make WordPress Core

Opened 6 years ago

Last modified 7 weeks ago

#48323 reviewing defect (bug)

Signup link redirect is not filtered on multisite when a blog is not found

Reported by: calin's profile calin Owned by: jjj's profile JJJ
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

The signup link redirect is not filtered for multisite when a blog is not found. Usually, the links are generated using network_site_url( 'wp-signup.php' ) which applies the network_site_url filter but not when a redirect occurs because the blog is not found.

The relevant piece of code is here: https://github.com/WordPress/WordPress/blob/5.2.3/wp-includes/ms-load.php#L396-L435

I know that this code loads before plugins, but it is loaded after sunrise.php, so the filter cand be added in that file.

I've attach a patch for this.

Attachments (1)

network_site_url.diff (783 bytes) - added by calin 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Networks and Sites

This ticket was mentioned in Slack in #core-multisite by realloc. View the logs.


8 months ago

This ticket was mentioned in Slack in #core-multisite by realloc. View the logs.


8 months ago

This ticket was mentioned in PR #8916 on WordPress/wordpress-develop by @realloc.


8 months ago
#4

This is the patch for the ticket: https://core.trac.wordpress.org/ticket/48323

#5 @realloc
7 months ago

  • Owner set to realloc
  • Status changed from new to assigned

#6 @realloc
7 months ago

  • Owner changed from realloc to JJJ
  • Status changed from assigned to reviewing

#7 @SergeyBiryukov
7 weeks ago

  • Milestone changed from Awaiting Review to 7.0
Note: See TracTickets for help on using tickets.