browse_happy() isn't used anywhere, remove it

[Viper007Bond]

The admin footer was redone and as a result, browse_happy() is no longer called anymore. Therefore, there's no need to define it.

And while we're on the subject of unused functions, there seems to be quite a few of them: ​http://xref.redalt.com/wptrunk/nav.htm?_functions/index.htm

I assume some need to be defined for use by plugins / backwards compatibility / etc., but I'm also sure at least some with 0 references can be removed. I'll leave that to someone more behind-the-scenes experienced than I though.

[f00f]

Let's first make it deprecated for some time. You never know which plugins might use it.

[JeremyVisser]

Huh? Why the heck would a plugin be using that function?

[f00f]

The wide-spread browse-happy plugin (TM). Honestly, I was also talking about all the other functions that are not referenced. And it is just good practice to not simply delete a function from one version to another.

[Speedboxer]

It's used 3 lines after it...

But, BrowseHappy should be gone from WordPress, anyways.

[Viper007Bond]

Dunno WTF I was thinking. We'll blame it on it being 4 AM when I made the ticket and that I was testing using Firefox, so I didn't realize it was still there.

[ocean90]

I want to reopen this ticket to get some new feedback.

• 3 years are now gone and the function is still in core.
  

• For 1,5 years its comment out in admin-footer.php, see [9964].
  

• browsehappy.com is not up2date, ​http://browsehappy.com/browsers/ where is Google Chrome and the other browsers?

• Code is poetry (comment out breaks it :))

• More discussion in #4254.

I think its time to say goodbye. :) (Yes I know it's Matt's domain, but maybe he will give his ok this time.)

[dd32]

Since this is only in the Admin template, I do not see a need to keep it around after 18 months..

If there are any objections to this, please speak up..

[JeremyVisser]

You have my full support. As ​Matt himself said:

Pruning is an important and necessary step in growing roses. Pruning keeps the plant healthy. It promotes new growth, removes dead, broken or diseased canes and trains roses to a desired shape. Pruning encourages flowering, either more blooms or larger blooms, and is essential to keep modern rose varieties blooming repeatedly all summer long.

[dd32]

wordpress: dd32 * r14233 /trunk/wp-admin/ (includes/template.php admin-footer.php): Remove dead browse happy code. Has not been used for 18months in core admin. Props ocean90. Fixes #4833

[Viper007Bond]

lol @ the ticket description. My how things have changed.