WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#4833 closed enhancement (fixed)

browse_happy() isn't used anywhere, remove it

Reported by: Viper007Bond Owned by:
Milestone: 3.0 Priority: lowest
Severity: trivial Version: 2.3
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

The admin footer was redone and as a result, browse_happy() is no longer called anymore. Therefore, there's no need to define it.

And while we're on the subject of unused functions, there seems to be quite a few of them: http://xref.redalt.com/wptrunk/nav.htm?_functions/index.htm

I assume some need to be defined for use by plugins / backwards compatibility / etc., but I'm also sure at least some with 0 references can be removed. I'll leave that to someone more behind-the-scenes experienced than I though.

Attachments (2)

browse_happy.patch (617 bytes) - added by Viper007Bond 13 years ago.
4833.patch (1.4 KB) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (14)

#1 @Viper007Bond
13 years ago

  • Milestone changed from 2.3 to 2.4 (next)

#2 @f00f
13 years ago

Let's first make it deprecated for some time. You never know which plugins might use it.

#3 @JeremyVisser
13 years ago

Huh? Why the heck would a plugin be using that function?

#4 @f00f
13 years ago

The wide-spread browse-happy plugin (TM). Honestly, I was also talking about all the other functions that are not referenced. And it is just good practice to not simply delete a function from one version to another.

#5 @Speedboxer
13 years ago

It's used 3 lines after it...

But, BrowseHappy should be gone from WordPress, anyways.

#6 @Viper007Bond
13 years ago

  • Component changed from Optimization to Administration
  • Keywords has-patch 2nd-opinion removed
  • Milestone 2.4 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Dunno WTF I was thinking. We'll blame it on it being 4 AM when I made the ticket and that I was testing using Firefox, so I didn't realize it was still there.

#7 @ocean90
10 years ago

  • Milestone set to 3.0
  • Resolution invalid deleted
  • Status changed from closed to reopened

I want to reopen this ticket to get some new feedback.

  • 3 years are now gone and the function is still in core.
  • For 1,5 years its comment out in admin-footer.php, see [9964].
  • Code is poetry (comment out breaks it :))
  • More discussion in #4254.

I think its time to say goodbye. :) (Yes I know it's Matt's domain, but maybe he will give his ok this time.)

@ocean90
10 years ago

#8 @dd32
10 years ago

Since this is only in the Admin template, I do not see a need to keep it around after 18 months..

If there are any objections to this, please speak up..

#9 @JeremyVisser
10 years ago

You have my full support. As Matt himself said:

Pruning is an important and necessary step in growing roses. Pruning keeps the plant healthy. It promotes new growth, removes dead, broken or diseased canes and trains roses to a desired shape. Pruning encourages flowering, either more blooms or larger blooms, and is essential to keep modern rose varieties blooming repeatedly all summer long.

#10 @blepoxp
10 years ago

  • Keywords has-patch added

#11 @dd32
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

wordpress: dd32 * r14233 /trunk/wp-admin/ (includes/template.php admin-footer.php): Remove dead browse happy code. Has not been used for 18months in core admin. Props ocean90. Fixes #4833

#12 @Viper007Bond
10 years ago

lol @ the ticket description. My how things have changed.

Note: See TracTickets for help on using tickets.