WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 8 days ago

#48333 assigned defect (bug)

Show success notice when the admin verification screen is "snoozed"

Reported by: desrosj Owned by: whyisjake
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Site Health Keywords: has-patch 2nd-opinion
Focuses: ui, administration Cc:
PR Number:

Description

When a user clicks "Remind me later" on the admin email verification screen, they are brought to the Dashboard and the screen will not show for 3 days. But the user is not shown a notice indicating the action has succeeded.

Attachments (1)

48333.diff (1.6 KB) - added by desrosj 2 months ago.

Download all attachments as: .zip

Change History (10)

@desrosj
2 months ago

#1 @desrosj
2 months ago

48333.diff adds an admin notification when the user is redirected to the Dashboard after clicking "Remind me later".

For now, I hard coded the number of days that the notice will be snoozed for, but I think that time period should filterable, just like admin_email_check_interval. That can be a separate ticket, though.

#2 @SergeyBiryukov
4 weeks ago

  • Milestone changed from Awaiting Review to 5.3.1

#3 @sathyapulse
3 weeks ago

@desrosj Do we need to consider the user's locale when displaying the success message? Refer #48313

#4 @Clorith
3 weeks ago

This will need a refresh as soon as #48334 lands (which I think is an important element to the reminder), but after that it should go in with 5.3.1

@sathyapulse #48313 shouldn't affect this, as the success notice is shown when you reach wp-admin.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 weeks ago

#6 @whyisjake
3 weeks ago

  • Owner set to whyisjake
  • Status changed from new to assigned

#7 @azaozz
3 weeks ago

  • Keywords 2nd-opinion added

Looking at 48333.diff the problem with this approach is that the query string may get "sticky" in some cases and then the message will be displayed "out of bounds" which will make it confusing.

For example if the user is redirected to a (plugin) screen that has a <form action="">, the query string will "carry over" after submitting that form and the message will be displayed again. Another edge case is making a browser bookmark when the query string is present. Then every time the bookmark is used, the same message will be displayed...

This was in the initial patch but was removed for that reason.

Another possible solution would be to set a transient when that message is needed, and remove it when the message is displayed. However that writes to the DB, twice. Still probably a better approach as these DB writes will only happen for logged-in users only when they click "remind me later".

Also, may be better to output that message from a function that is added on a hook in the admin? Perhaps admin_init or similar.

Last edited 3 weeks ago by azaozz (previous) (diff)

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


8 days ago

#9 @audrasjb
8 days ago

  • Milestone changed from 5.3.1 to 5.4

Even if this enhancement would fit very well with WP 5.3.1 scope, we realistically don't have the timeframe to give it proper attention. Moving it to the next release.

Note: See TracTickets for help on using tickets.