WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#48337 closed defect (bug) (fixed)

Yoda condition fix in Rest API

Reported by: mukesh27's profile mukesh27 Owned by: whyisjake's profile whyisjake
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: REST API Keywords: good-first-bug has-patch
Focuses: rest-api, coding-standards Cc:

Description

When I checking #48335 ticket found below issue.

Yoda condition in /wp-includes/rest-api/class-wp-rest-request.php as per ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions document

Attachments (1)

48337.diff​ (471 bytes) - added by mukesh27 6 years ago.
Patch.

Download all attachments as: .zip

Change History (6)

@mukesh27
6 years ago

Patch.

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.4

#2 @spenserhale
6 years ago

I reviewed this patch and agree it is save to merge in.

#3 @whyisjake
6 years ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from new to closed

In 46639:

REST API: Fix for Yoda condition.

Little coding standards fix for the REST API.

Props mukesh27, spenserhale.
Fixes #48337.

#4 @whyisjake
6 years ago

In 46653:

Revert: Undo r46639.

This was meant to be committed to /trunk.

See #48337.

#5 @whyisjake
6 years ago

In 46654:

REST API: Fix for Yoda condition.

Little coding standards fix for the REST API.

Props mukesh27, spenserhale.

Fixes #48337.

Note: See TracTickets for help on using tickets.